Disable remote assistance for local login

[PeterJhongLinksys]

Summary

Disable the remote assistance feature for local login sessions.

Changes

• Skip the active remote session check during polling (polling_provider), which prevents the passive remote assistance dialog from being triggered in the dashboard shell for local login.
• Hide the support agent button in the top bar that launches the remote assistance dialog.
• Apply dart format to the touched files (line wrapping and indentation only, no logic changes).

Notes

The remote assistance code is commented out (not removed) so it can be easily restored later.

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[AustinChangLinksys]

🤖 Automated Review — Round 1 · 0fc8374..9e383d1 (full)

Verdict: ✅ APPROVE — Remote assistance correctly disabled at both entry points (TopBar button + polling session check); no security or correctness issues found. 5 housekeeping warnings to clean up before re-enabling the feature.

	Conf.	Where	Issue (one-liner)
⚠️	🟢High	polling_provider.dart:18	[both reviewers] Dead import — remote_client_provider.dart import remains but its only callsite is now commented out
⚠️	🟢High	polling_provider.dart:183	[both reviewers] Dead variable loginType — assigned but never consumed; causes unnecessary authProvider read on every polling tick
⚠️	🟢High	top_bar.dart:12	[both reviewers] Dead import — remote_assistance_dialog.dart import remains but its only callsite (showRemoteAssistanceDialog) is commented out
⚠️	🟡Med	dashboard_shell.dart:44–72	[both reviewers] Passive auto-popup path not annotated — ref.listen on remoteClientProvider.sessionInfo can still trigger showRemoteAssistanceDialog for local login if session state changes; currently unreachable but undocumented landmine
⚠️	🟢High	test/	[single — Reviewer B] No regression test asserting Icons.support_agent is absent for LoginType.local after button removal
💡	—	polling_provider.dart:184, top_bar.dart:149	TODO comments carry no ticket reference — add // TODO(#TICKET): re-enable when remote assistance is ready
💡	—	add_nodes_provider.dart:161–177	Pre-existing (not introduced by this PR): childNodes.sort(), polling.forcePolling(), and state.copyWith(isLoading: false) run unconditionally outside the if (onboardingProceed && anyOnboarded) guard — worth confirming intentional
💡	—	add_nodes_provider.dart:107	Pre-existing: var deviceOnboardingStatus = [] is untyped (List<dynamic>); opportunity to tighten type in this formatter pass

Confidence: 🟢High = code-verified · 🟡Med = located + reasoned, not fully confirmed · ⚪Low = speculative, please double-check.
Items marked [both reviewers] were independently flagged by two agents → higher confidence.

⚠️ Warning Details

W-1: Dead import in polling_provider.dart 🟢High [both reviewers]

• Location: lib/core/jnap/providers/polling_provider.dart:18
• Evidence: import 'package:privacy_gui/core/cloud/providers/remote_assistance/remote_client_provider.dart'; — the only callsite ref.read(remoteClientProvider.notifier).checkActiveSession() is commented out at lines 185–188. No other reference to remoteClientProvider in this file.
• Impact: unused_import lint warning; CI configs that treat warnings-as-errors will break the build.
• Fix: Remove line 18, or guard with a compile-time feature flag.

W-2: Dead variable loginType in polling_provider.dart 🟢High [both reviewers]

• Location: lib/core/jnap/providers/polling_provider.dart:183

final loginType = ref.read(authProvider).value?.loginType;
// TODO: Disable remote assistance for now
// logger.i('[Polling]: _additionalPolling loginType: $loginType');
// if (loginType == LoginType.local) { ... }

• Impact: Variable is assigned (triggering ref.read(authProvider) on every polling cycle) but never consumed. Produces an unused_local_variable lint warning.
• Fix: Comment out or remove the loginType declaration alongside the block it guarded.

W-3: Dead import in top_bar.dart 🟢High [both reviewers]

• Location: lib/page/components/styled/top_bar.dart:12
• Evidence: import '...remote_assistance_dialog.dart' — the only callsite showRemoteAssistanceDialog(context, ref) is commented out at lines 149–159. _startRemoteAssistance() (remote-login path) calls showSimpleAppDialog + initiateRemoteAssistanceCA(), not showRemoteAssistanceDialog.
• Fix: Remove line 12.

W-4: Passive remote-assistance listener not annotated in dashboard_shell.dart 🟡Med [both reviewers]

• Location: lib/page/dashboard/views/dashboard_shell.dart:44–72
• Evidence:

ref.listen(
  remoteClientProvider.select((state) => state.sessionInfo?.status),
  (prevStatus, nextStatus) {
    final loginType = ref.read(authProvider).value?.loginType;
    if (loginType != LoginType.local) return;
    if (prevStatus != GRASessionStatus.active &&
        nextStatus == GRASessionStatus.active && ...) {
      showRemoteAssistanceDialog(context, ref, isPassive: true);
    }
  },
);

• Current state: Currently unreachable — checkActiveSession() was the only path that could update sessionInfo for local login, now commented out. Manual button also commented out.
• Risk: The TODO in polling_provider.dart / top_bar.dart signals a temporary disable. The passive listener carries no matching TODO. Any future commit adding a sessionInfo update path for local login will silently reactivate the dialog.
• Fix: Add // TODO(#TICKET): re-enable when remote assistance is restored comment, or stub the listener body with an explicit guard.

W-5: No regression test for support_agent button removal 🟢High [single — Reviewer B]

• Location: test/page/components/styled/top_bar_test.dart
• Issue: Existing TopBar tests do not assert that Icons.support_agent is absent when loginType == LoginType.local. The UI entry-point removal is unverified.
• Fix: Add: expect(find.byIcon(Icons.support_agent), findsNothing) in a LoginType.local scenario test.

✅ What Looks Good

• Both entry points disabled together: checkActiveSession() in _additionalPolling (polling path) and the support_agent button in TopBar (manual path) are both commented out in the same PR — no half-open state.
• Remote-login path fully preserved: _startRemoteAssistance(), initiateRemoteAssistanceCA(), the session-expire counter, and endRemoteAssistance flows are all untouched.
• checkActiveSession() is safely removable: The method wraps all cloud calls in try/catch; removing it from the polling loop cannot crash or corrupt state.
• add_nodes_provider.dart diff is semantically neutral: The indentation fix re-aligns the block to the enclosing try scope; control flow (childNodes.sort() etc. running unconditionally) is identical before and after.
• pnp_admin_view.dart and pnp_setup_view.dart: Formatter-only line-wrap changes to .catchError chains — no logic altered.
• No hardcoded secrets, no injection surface, no JNAP result-code bypass anywhere in the diff.
• remoteClientProvider correctly non-autoDispose (global session singleton); AddNodesNotifier correctly autoDispose (page-scoped). Layer boundaries respected.

Cross-reviewed by two independent agents (security+correctness / architecture+maintainability). Automated — please sanity-check before merge.