Skip to content

feat: add OpenAPI schema build to release workflow - #1050

Merged
j-zimnowoda merged 2 commits into
mainfrom
APL-2038
Aug 6, 2026
Merged

feat: add OpenAPI schema build to release workflow#1050
j-zimnowoda merged 2 commits into
mainfrom
APL-2038

Conversation

@CasLubbers

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 5, 2026 14:29
@CasLubbers
CasLubbers marked this pull request as ready for review August 5, 2026 14:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds OpenAPI schema generation to the release workflow so the schema JSON can be published alongside each GitHub Release.

Changes:

  • Set up Node.js in the release-software job.
  • Run the OpenAPI/model build (npm ci + npm run build:models) during release.
  • Upload the generated schema JSON as a release asset (skipped on dry_run).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release-software.yml
Copilot AI review requested due to automatic review settings August 6, 2026 07:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

.github/workflows/release-software.yml:115

  • This adds schema build/upload after the GitHub Release is created. If the schema build fails, the workflow will leave behind a published release (and potentially pushed image) without the OpenAPI asset. Also, gh release upload will fail on workflow reruns if the asset already exists. Consider (1) building the schema before creating the release, (2) using .nvmrc for the Node version to avoid duplicating version bumps, (3) using GH_TOKEN for gh (matching other workflows here), and (4) adding --clobber to make reruns idempotent.
      - name: Set up Node.js
        uses: actions/setup-node@v4
        with:
          node-version: 24

@j-zimnowoda
j-zimnowoda enabled auto-merge (squash) August 6, 2026 09:50
@j-zimnowoda
j-zimnowoda merged commit 2280a39 into main Aug 6, 2026
8 checks passed
@j-zimnowoda
j-zimnowoda deleted the APL-2038 branch August 6, 2026 10:58
j-zimnowoda pushed a commit that referenced this pull request Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants