feat: update add new helm chart #653
Conversation
CasLubbers
left a comment
CasLubbers
left a comment
There was a problem hiding this comment.
Thinking of it why did we not use Helm for fetching the charts? Then we didn't need all the url parsing.
We can maybe add extra ticket to also have a option to add a chart via Helm?
Good question. Some charts are only hosted in go repo. However the URL part is tricky because, it is not the URL to git repository but to a web page. How does the user know which URL should be used? |
CasLubbers
left a comment
CasLubbers
left a comment
There was a problem hiding this comment.
Code looks good to me 👍
We discussed that issue and the for description provide a guidance to a user. |
Sure but we can create follow-up ticket so that a user can decide to choose helm or git? to add the chart. I would personally like helm because that is what I am used to for using charts. |
* feat: update add new helm chart * feat: update support for gitlab * fix: normalizedUrl & code conventions * fix: gitlab regex * feat: add GIT_PROVIDER_URL_PATTERNS env --------- Co-authored-by: jeho <17126497+j-zimnowoda@users.noreply.github.com> (cherry picked from commit f7d6e3e)
* fix(git save): increase git pull retries and remove doRestore (#651) Git pull retries have increase to 10 and doRestore have been replaced with always cleaning the session Co-authored-by: Jehoszafat Zimnowoda <17126497+j-zimnowoda@users.noreply.github.com> (cherry picked from commit a8ae5ef) * fix: add policies to api check (#652) * fix: add policies to api check (cherry picked from commit 4d384f2) * feat: update fetch workload catalog (#655) (cherry picked from commit b5db0b4) * feat: update add new helm chart (#653) * feat: update add new helm chart * feat: update support for gitlab * fix: normalizedUrl & code conventions * fix: gitlab regex * feat: add GIT_PROVIDER_URL_PATTERNS env --------- Co-authored-by: jeho <17126497+j-zimnowoda@users.noreply.github.com> (cherry picked from commit f7d6e3e) * fix: create service & form validation nullable error (#656) (cherry picked from commit b52712d) * chore(release): 3.7.1 * fix: create policies with the new team creation (#657) * fix: create policies with the new team creation * fix: create policies for teams (cherry picked from commit f4e556e) * chore(release): 3.7.2 --------- Co-authored-by: CasLubbers <clubbers@akamai.com>
Implement
https://jira.linode.com/browse/APL-556
Description
This PR updated the add new helm chart flow and adds support for git providers.
Is paired with: linode/apl-console#524