-
Notifications
You must be signed in to change notification settings - Fork 12
Table header icon updates, new component tokens #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Release v4.1.0 - staging → main
| "description": "Hover color for an active calendar date" | ||
| }, | ||
| "active": { | ||
| "tertiaryActive": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are breaking changes - @jaalah-akamai how do we handle those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically bump to a major version for breaking changes
|
@davyd-akamai Can you provide some mappings for the breaking changes? It seems teams would have to map |
Good call! Description has been updated |
|
@jaalah-akamai @abailly-akamai I think it’s ready for one more review. The plugin optimization I mentioned during our meeting could be moved to the next version, as it requires additional time for investigation. |
abailly-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! we will just need a version bump for the breaking change
|
There's a few issues we need to resolve: I'll resolve them in code |
|
@davyd-akamai |
Is it something I've broken with a new naming conventions? |
interaction.background.*tokensNew token name <- Old noken name:
interaction.background.primaryHover<-interaction.background.elevatedinteraction.background.secondaryHover<-interaction.background.rangeHoverinteraction.background.secondaryActive<-interaction.background.accentinteraction.background.tertiaryHover<-interaction.background.activeDateHoverinteraction.background.tertiaryActive<-interaction.background.activeNew token:
interaction.background.primaryActive(brand.30/neutrals.80) - selected state for a dropdown item, list item, etc;New component tokens for a Tile component
New behaviour of a table header icons:
icon.default,icon.hover, andicon.activetokens under each type of table header.icon onlytable header now usealias.content.icon.primary token.