Skip to content

Conversation

@davyd-akamai
Copy link
Collaborator

@davyd-akamai davyd-akamai commented Apr 17, 2025

  1. Interaction tokens optimisation: new naming convention for interaction.background.* tokens

New token name <- Old noken name:

  • interaction.background.primaryHover <- interaction.background.elevated
  • interaction.background.secondaryHover <- interaction.background.rangeHover
  • interaction.background.secondaryActive <- interaction.background.accent
  • interaction.background.tertiaryHover <- interaction.background.activeDateHover
  • interaction.background.tertiaryActive <- interaction.background.active

New token: interaction.background.primaryActive (brand.30/neutrals.80) - selected state for a dropdown item, list item, etc;

  1. New component tokens for a Tile component

  2. New behaviour of a table header icons:

  • (Major change) The icon token that was used for the sort icon has been split into icon.default, icon.hover, and icon.active tokens under each type of table header.
  • The info icon no longer uses alias tokens, but table component tokens instead.
  • Icon inside of an icon only table header now use alias.content.icon.primary token.
  1. Elevation tokens for a drawer component

@davyd-akamai davyd-akamai self-assigned this Apr 17, 2025
@davyd-akamai davyd-akamai changed the title Table header icon updates Table header icon updates, new component tokens May 26, 2025
@davyd-akamai davyd-akamai marked this pull request as ready for review June 5, 2025 11:01
"description": "Hover color for an active calendar date"
},
"active": {
"tertiaryActive": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are breaking changes - @jaalah-akamai how do we handle those?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically bump to a major version for breaking changes

@jaalah-akamai
Copy link
Collaborator

@davyd-akamai Can you provide some mappings for the breaking changes? It seems teams would have to map rangeHover, activeDateHover, accent, elevated, active to something new. I just want to be clear what that should be for eng teams.

@davyd-akamai
Copy link
Collaborator Author

@davyd-akamai Can you provide some mappings for the breaking changes? It seems teams would have to map rangeHover, activeDateHover, accent, elevated, active to something new. I just want to be clear what that should be for eng teams.

Good call! Description has been updated

@davyd-akamai
Copy link
Collaborator Author

davyd-akamai commented Jul 30, 2025

@jaalah-akamai @abailly-akamai I think it’s ready for one more review. The plugin optimization I mentioned during our meeting could be moved to the next version, as it requires additional time for investigation.

Copy link
Collaborator

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! we will just need a version bump for the breaking change

@jaalah-akamai
Copy link
Collaborator

There's a few issues we need to resolve:

component.table.row.background.hover.value tries to reference alias.interaction.background.elevated, which is not defined.
component.calendar.selectedItem.background.default.value tries to reference alias.interaction.background.active, which is not defined.
component.calendar.selectedItem.background.hover.value tries to reference alias.interaction.background.activeDateHover, which is not defined.
component.calendar.hoverItem.background.value tries to reference alias.interaction.background.elevated, which is not defined.
component.calendar.dateRange.background.default.value tries to reference alias.interaction.background.elevated, which is not defined.
component.calendar.dateRange.background.hover.value tries to reference alias.interaction.background.rangeHover, which is not defined.
component.calendar.presetArea.activePeriod.background.value tries to reference alias.interaction.background.accent, which is not defined.
component.sideNavigation.selectedMenuItem.background.value tries to reference alias.interaction.background.accent, which is not defined.
component.stepper.horizontal.pastItem.circle.background.hover.value tries to reference alias.interaction.background.active, which is not defined.
component.stepper.horizontal.currentItem.circle.background.value tries to reference alias.interaction.background.active, which is not defined.
component.stepper.vertical.currentItem.circle.background.value tries to reference alias.interaction.background.active, which is not defined.

I'll resolve them in code

@jaalah-akamai
Copy link
Collaborator

@davyd-akamai
✅ Ignore the dist folder, but the changes have been made to calendar.json, sideNavigation.json, stepper.json, and table.json
✅ Tokens all build correctly now

@davyd-akamai
Copy link
Collaborator Author

davyd-akamai commented Aug 11, 2025

There's a few issues we need to resolve:

Is it something I've broken with a new naming conventions?

@jaalah-akamai jaalah-akamai merged commit 27c9d19 into linode:staging Aug 11, 2025
1 check passed
@davyd-akamai davyd-akamai deleted the updates branch August 13, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants