upcoming: [M3-10326] - VM Host Maintenance - Status Icon, Copy Updates, Conditional Notice Display #12512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, Conditional Notice Display
jaalah-akamai
requested review from
hana-akamai and
pmakode-akamai
and removed request for
a team
jaalah-akamai
added
Ready for Review
Work in Progress
and removed
Missing Changeset
Ready for Review
labels
Contributor
Author
|
Moving back to draft: I want to investigate one more thing regarding |
hana-akamai
approved these changes
Jul 16, 2025
pmakode-akamai
approved these changes
Jul 18, 2025
| "@linode/api-v4": Removed | ||
| --- | ||
|
|
||
| Remove unnecessary in-progress event.status type during earlier development ([#12512](https://github.com/linode/manager/pull/12512)) |
Contributor
There was a problem hiding this comment.
Suggested change
| Remove unnecessary in-progress event.status type during earlier development ([#12512](https://github.com/linode/manager/pull/12512)) | |
| Unnecessary in-progress event.status type during earlier development ([#12512](https://github.com/linode/manager/pull/12512)) |
pmakode-akamai
added
Approved
Collaborator
Cloud Manager UI test results🎉 690 passing tests on test run #9 ↗︎
|
jaalah-akamai
added a commit
that referenced
this pull request
Jul 24, 2025
…s, Conditional Notice Display (#12512) * upcoming: [M3-10326] - VM Host Maintenance - Status Icon, Copy Updates, Conditional Notice Display * Remove in-progress event status type - added erroneously * Add changesets * Add iconSlot to TableSortCell * Fix issue with filtering and address reason field when empty * Update test with latest utilities --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
This was referenced Jul 24, 2025
dchyrva-akamai
pushed a commit
to dchyrva-akamai/manager
that referenced
this pull request
Jul 28, 2025
…s, Conditional Notice Display (linode#12512) * upcoming: [M3-10326] - VM Host Maintenance - Status Icon, Copy Updates, Conditional Notice Display * Remove in-progress event status type - added erroneously * Add changesets * Add iconSlot to TableSortCell * Fix issue with filtering and address reason field when empty * Update test with latest utilities --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes 🔄
Start DateandEnd Datewhere we were using the display label instead of the field name (start_time,complete_time)Target release date 🗓️
7/29
Preview 📷
Note: Table icon color tokens are incorrect and will be updated here. So the info icon is the correct color, but the directional arrows are not. The underlying token is correct so we will inherit the fix in the next version bump
notice-before.mov
notice.mov
How to test 🧪
Verification steps
Notice Verification
Helper Text - Linode Create
Tooltip Verification
upcomingandstatuscell has a tooltip.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅