[fix] : add context timeout when making listNodes k8s call#361
Merged
Conversation
…er doesn't respond
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 72.95% 72.98% +0.03%
==========================================
Files 14 14
Lines 2596 2599 +3
==========================================
+ Hits 1894 1897 +3
Misses 537 537
Partials 165 165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
komer3
approved these changes
Mar 26, 2025
hcwagner
pushed a commit
to hcwagner/linode-cloud-controller-manager
that referenced
this pull request
Jun 11, 2025
…er doesn't respond (linode#361)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix adds a timeout for listNodes k8s call so that if apiserver is not responding, the call should timeout after some time and not hang indefinitely somehow.
General:
Pull Request Guidelines: