Skip to content

Conversation

@zliang-akamai
Copy link
Member

No description provided.

zliang-akamai and others added 2 commits August 14, 2023 13:58
## 📝 Description

Better dev experience with an IDE or text editor with this typing.
## 📝 Description

Fix an issue in `ip_addresses_share` to allow it unshare IPs. 

In the API doc, entering an empty IP array is allowed and it means
removing the shared IPs from the Linode. In the previous implementation,
we always looked for `ips[0]` when building the request param. It
brought the index out of range error when an empty IP array is given.

## ✔️ How to Test

`tox`
@zliang-akamai zliang-akamai requested a review from a team as a code owner August 15, 2023 16:45
Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Zhiwei!

@yec-akamai yec-akamai requested a review from a team August 15, 2023 16:56
@zliang-akamai zliang-akamai merged commit a6fda9c into main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants