Feat: adding flexible placement group limit - #1038
Merged
zliang-akamai merged 4 commits intoSep 3, 2026
Merged
Conversation
avnimish
requested review from
psnoch-akamai and
zliang-akamai
and removed request for
a team
August 31, 2026 17:41
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request extends the RegionPlacementGroupLimits model in the root linodego API client to surface the API’s “flexible placement group” Linode limit returned by the Regions endpoints, and updates unit/integration tests and fixtures accordingly.
Changes:
- Added
MaximumLinodesPerFlexiblePGtoRegionPlacementGroupLimitswith the corresponding JSON field mapping. - Updated unit fixtures and unit tests to validate the new field is populated.
- Updated the integration
TestRegions_pgLimitsto assert the new limit is non-zero.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
regions.go |
Adds MaximumLinodesPerFlexiblePG to RegionPlacementGroupLimits for Regions API responses. |
test/unit/region_test.go |
Extends unit assertions to validate MaximumLinodesPerFlexiblePG is present and > 0 when limits exist. |
test/unit/fixtures/regions_list.json |
Updates the regions list fixture to include maximum_linodes_per_flexible_pg. |
test/unit/fixtures/region_get.json |
Updates the region get fixture to include maximum_linodes_per_flexible_pg. |
test/integration/regions_test.go |
Extends the placement-group limits integration test to assert MaximumLinodesPerFlexiblePG is non-zero. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zliang-akamai
approved these changes
Sep 3, 2026
psnoch-akamai
approved these changes
Sep 3, 2026
psnoch-akamai
left a comment
psnoch-akamai
left a comment
Contributor
There was a problem hiding this comment.
LGTM and tests work locally
* TPT-4463: Support RDMA VPC interfaces (linode#988) * init * lint * address comments for omitzero * lint * update comment * fix interfaces list * fix lint * Fix RDMA project branch merge from v2 (linode#1003) * fix v2 * udpate * TPT-4463: Add integration tests for RDMA interfaces (linode#999) * init # Conflicts: # interfaces.go # regions.go # test/unit/fixtures/interface_list_with_rdma.json # test/unit/rdma_vpc_test.go # vpc.go * address comments for omitzero * Refactor vpcCreateOptionsCheck to use createOpts Current implementation of vpcCreateOptionsCheck verifies fields copied from VPC so comparing opts.Label == vpc.Label etc. is just comparing a value to itself —> good is always true. * Update fixtures * Create int tests for VPC and VPC Subnet with RDMA type * Add assertion for regular VPC type * Update vpcCreateOptionsCheck to use require * Update error msg in TestVPC_Update_Invalid * Update fixtures for TestVPC_List tests * Update err msg for invalid label in VPC and Subnet tests * Add negative TCs for RDMA VPC with IPv6 * Create int test for Linode instance with RDMA interfaces * Refactor createInstanceWithLinodeInterfaces to use LinodeInstanceInterfaceCreateOptions * Refactor TestInstance_CreateWithRDMAVPCInterfaces to use createInstanceWithLinodeInterfaces * Small refactor & fixture update * Linter * Comment out TestInstance_CreateWithRDMAVPCInterfaces due to infra changes needed * Update comment for TestVPC_WithRDMATypeIPv6_Fail * Update fixtures for TestVPC_CreateGet_smoke and TestVPC_Subnet_Create * Update fixtures and TestVPC_IPv4Ranges to return 4 vals in createVPC * Update TestInstance_CreateWithRDMAVPCInterfaces * Address Copilot remarks * Uncomment TestVPC_WithRDMATypeAndIPv6_Fail as IPv6 is blocked already --------- Co-authored-by: Ye Chen <yechen@akamai.com> * fix conflict * Add booted=false for RDMA Linode instance creation * TPT-4456: Enable integration test for RDMA Linode interface (linode#1032) * add for passing tests * update test * disable cfw * add pointers to omitzero fields * fmt --------- Co-authored-by: Maciej Wilk <mawilk@akamai.com>
avnimish
force-pushed
the
feat/adding-flexible-placement-group-limit
branch
from
September 3, 2026 16:51
1269f79 to
71d2f23
Compare
zliang-akamai
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This change adds the flexible placement group limit as a field in the PlacementGroupLimits to use when provisioning Placement groups
✔️ How to Test