Skip to content

fix: [M3-7625] – Update VPC docs links with published docs#10050

Merged
dwiley-akamai merged 9 commits intolinode:stagingfrom
dwiley-akamai:hotfix/vpc-docs-links
Jan 10, 2024
Merged

fix: [M3-7625] – Update VPC docs links with published docs#10050
dwiley-akamai merged 9 commits intolinode:stagingfrom
dwiley-akamai:hotfix/vpc-docs-links

Conversation

@dwiley-akamai
Copy link
Copy Markdown
Contributor

@dwiley-akamai dwiley-akamai commented Jan 9, 2024

Description 📝

Update several placeholder links with the published VPC docs links

Changes 🔄

  • Update links to VPC docs
  • Organize constants.ts file better

How to test 🧪

Verification steps

Confirm that:

  1. The “Docs” link in the entity header on the VPC landing and VPC Detail pages point at https://www.linode.com/docs/products/networking/vpc/
  2. The “Getting Started” link in the entity header on the VPC Create page points at https://www.linode.com/docs/products/networking/vpc/get-started/
  3. When trying to assign a linode with multiple configuration profiles, the "Learn More" link points at https://www.linode.com/docs/products/compute/compute-instances/guides/configuration-profiles/
  4. There are no broken docs links throughout the VPC feature

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@dwiley-akamai dwiley-akamai added Hotfix Hotfix: This is going to staging VPC Relating to VPC project labels Jan 9, 2024
@dwiley-akamai dwiley-akamai self-assigned this Jan 9, 2024
@dwiley-akamai dwiley-akamai marked this pull request as ready for review January 10, 2024 15:14
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner January 10, 2024 15:14
@dwiley-akamai dwiley-akamai requested review from bnussman-akamai, cliu-akamai and cpathipa and removed request for a team January 10, 2024 15:14
@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Jan 10, 2024
Comment thread packages/manager/CHANGELOG.md Outdated
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Confirming that the doc links are correctly pointing to their respective pages.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 10, 2024

Coverage Report:
Base Coverage: 79.16%
Current Coverage: 79.16%

Copy link
Copy Markdown
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All updated links went to the described pages; didn't find any broken links. Changelog date is accurate now. 🚀

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 10, 2024
@dwiley-akamai dwiley-akamai merged commit dccd829 into linode:staging Jan 10, 2024
@dwiley-akamai dwiley-akamai deleted the hotfix/vpc-docs-links branch January 10, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Hotfix Hotfix: This is going to staging VPC Relating to VPC project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants