upcoming: [M3-7704] - Disable Cloning, Private IP, Backups for edge regions by hana-akamai · Pull Request #10222 · linode/manager

hana-akamai · 2024-02-22T18:30:20Z

Description 📝

Cloning, Private IP, Backups, Lish Console via SSH, and VPC will not be supported for edge regions so we want to disable them.

Changes 🔄

Disabled the Backups and Private IP checkbox in the Linode Create page when an edge region is selected and display a warning notice
Disabled Private IP radio in the "Add an IP Address" drawer (Linode details page -> Network tab -> Add An IP Address) for Linodes in an edge region with a warning notice
Disabled the "Enable Backups" button in the Backups tab of the Linode details page with a warning notice
Disabled the "Clone" action in the Linode landing dropdown action menu and Linode entity detail action menu with a tooltip explanation
Updated LISH Console via SSH text in Linode Entity Detail Header to N/A

Preview 📷

How to test 🧪

Prerequisites

(How to setup test environment)

Turn on the MSW

Verification steps

(How to verify changes)

See the Changes section

yarn test AddonsPanel
yarn test BackupsPlaceholder
yarn test AddIPDrawer
yarn test LinodeActionMenu

As an Author I have considered 🤔

Check all that apply

…ions

…s-edge-regions

packages/manager/src/features/Linodes/LinodesLanding/LinodeActionMenu/LinodeActionMenu.test.tsx

packages/manager/src/components/RegionSelect/RegionSelect.utils.ts

packages/manager/src/features/Linodes/LinodesDetail/LinodeBackup/BackupsPlaceholder.tsx

github-actions · 2024-03-05T19:43:00Z

Coverage Report: ✅
Base Coverage: 81.39%
Current Coverage: 81.4%

dwiley-akamai

Unit tests pass ✅

Linode Create page: Backups & Private IP checkboxes disabled & warning notice displayed when Edge region is selected ✅

Disabled Private IP radio in the "Add an IP Address" drawer (Linode details page -> Network tab -> Add An IP Address) for Linodes in an Edge region with a warning notice ✅

Disabled the "Enable Backups" button in the Backups tab of the Linode details page with a warning notice ✅

Disabled the "Clone" action in the Linode landing dropdown action menu and Linode entity detail action menu with a tooltip explanation ✅

jaalah-akamai · 2024-03-06T15:55:47Z

Instead of a notice for the backups section. Can we add tooltip text to the disabled button? I think that's a cleaner approach that we've been doing elsewhere. Same for the "Add an IP Address" notice. We they can't edit/modify anything in the drawer, let's just disable the "Add an IP Address" button with tooltip text

hana-akamai · 2024-03-06T16:10:36Z

@jaalah-akamai Backups has been addressed in an earlier commit, just updated the preview screenshot to reflect the change. For the "Add an IP Address" drawer, the user can still edit/modify most things in the drawer (just not Private IPv4) so I think the warning notice makes sense there

jaalah-akamai · 2024-03-07T21:16:31Z

packages/manager/src/features/Linodes/LinodesDetail/LinodeNetworking/AddIPDrawer.tsx

+          {linodeIsInEdgeRegion && (
+            <Notice
+              sx={{ fontSize: 15 }}
+              text="Private IP is currently not available for Edge regions"


Nit: If you look at all the notice/tooltip texts that are similar, we could probably create a util where we pass in an action or resourceType and get the verbiage and syntax aligned. We're starting to do this with our restricted user experience messaging. https://github.com/linode/manager/blob/develop/packages/manager/src/features/Account/utils.ts#L44-L67

…s-edge-regions

…eature/namespace-create * 'develop' of https://github.com/vrajesh73/manager: (89 commits) fix: [M3-7269] - Display parent email in user menu when no company name is available for restricted parent user (linode#10248) fix: [M3-7817] - Show correct status of Child Account Enabled column for parent users (linode#10233) upcoming: [M3-7616] - Add Placement Groups Events and Notifications (linode#10221) upcoming: [M3-7816-v2] - Adjust logic for when to show Switch Account button (linode#10266) fix: [M3-7831] - Persisting error messages in ACLB delete dialogs (linode#10254) upcoming: [M3-7842] - Update Assign Linode Drawer and improve query skipping (linode#10263) upcoming: [M3-7704] - Disable Cloning, Private IP, Backups for edge regions (linode#10222) test: Fix test flake for Images landing page test (linode#10267) fix: [M3-7824] - ACLB TCP Rule Creation and other fixes (linode#10264) refactor: [M3-7687] - Linodes Restricted User Experience 2/2 (linode#10227) test: Resolve OBJ create and delete E2E test flake (linode#10245) upcoming: [M3-7723] - Placement Group feature flag as object (linode#10256) chore(deps): Bump sanitize-html from 2.11.0 to 2.12.1 (linode#10247) change: [M3-7813] - Allow the disabling of the TypeToConfirm input (linode#10251) upcoming: [M3-7839] - Change Business Partner to Parent User (linode#10259) upcoming: [M3-7835] - Adjust user table column count (linode#10252) upcoming: [M3 7738] - Update Placement Group Create & Edit Drawers (linode#10205) refactor: [M3-7437] - Use `@lukemorales/query-key-factory` for Profile Queries (linode#10241) fix: React Query `updateInPaginatedStore` helper function not working as expected (linode#10249) test: [M3-7497] - Add tests for child user verification banner (linode#10204) ... # Conflicts: # packages/manager/src/MainContent.tsx # packages/manager/src/dev-tools/FeatureFlagTool.tsx

hana-akamai added the Gecko Beta Relating to Gecko project label Feb 22, 2024

hana-akamai self-assigned this Feb 22, 2024

hana-akamai force-pushed the M3-7704-disable-cloning-private-ip-backups-edge-regions branch 2 times, most recently from 72451ec to fbad1a4 Compare February 26, 2024 15:42

hana-akamai added 8 commits February 26, 2024 10:46

disable backups and private ip checkbox in linode create for edge reg…

19dc599

…ions

disable private ip radio in Add an IP Address drawer

3c04078

disable backups in linode details backups tab

35a1ead

hide linodes in an edge region in the linode create backups tab

9a508cf

disable clone dropdown action for linodes in an edge region

97cc5a8

hide linodes in an edge region in the linode create clone tab

f5b3f20

disable clone action in linode entity detail header

2d0525e

add unit tests

52cc34a

hana-akamai force-pushed the M3-7704-disable-cloning-private-ip-backups-edge-regions branch from fbad1a4 to 52cc34a Compare February 26, 2024 16:00

hana-akamai added 6 commits February 26, 2024 15:07

clean up

08a050b

Added changeset: Disable Cloning, Private IP, Backups for edge regions

344e8b4

Merge branch 'develop' into M3-7704-disable-cloning-private-ip-backup…

53ef535

…s-edge-regions

fix unit tests

8216d5b

Merge branch 'develop' into M3-7704-disable-cloning-private-ip-backup…

e60f85b

…s-edge-regions

clean up

cf38438

hana-akamai marked this pull request as ready for review March 4, 2024 23:05

hana-akamai requested a review from a team as a code owner March 4, 2024 23:05

hana-akamai requested review from bnussman-akamai and cpathipa and removed request for a team March 4, 2024 23:05

bnussman-akamai reviewed Mar 5, 2024

View reviewed changes

address feedback

453889e

hana-akamai requested review from bnussman-akamai and jaalah-akamai March 5, 2024 17:35

update unit test

2b06c8f

dwiley-akamai self-requested a review March 5, 2024 19:53

dwiley-akamai approved these changes Mar 5, 2024

View reviewed changes

hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Mar 6, 2024

change lish via ssh text to n/a

7f1ef3a

jaalah-akamai approved these changes Mar 7, 2024

View reviewed changes

jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 7, 2024

hana-akamai added the Wait to Merge label Mar 7, 2024

jaalah-akamai approved these changes Mar 7, 2024

View reviewed changes

Merge branch 'develop' into M3-7704-disable-cloning-private-ip-backup…

fd0eab8

…s-edge-regions

hana-akamai merged commit 95ba193 into linode:develop Mar 7, 2024

This was referenced Mar 18, 2024

Release v1.115.0 - release → staging #10292

Merged

Release v1.115.0 - staging → master #10293

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming: [M3-7704] - Disable Cloning, Private IP, Backups for edge regions#10222

upcoming: [M3-7704] - Disable Cloning, Private IP, Backups for edge regions#10222
hana-akamai merged 18 commits intolinode:developfrom
hana-akamai:M3-7704-disable-cloning-private-ip-backups-edge-regions

hana-akamai commented Feb 22, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2024 •

edited

Loading

Uh oh!

dwiley-akamai left a comment

Uh oh!

jaalah-akamai commented Mar 6, 2024 •

edited

Loading

Uh oh!

hana-akamai commented Mar 6, 2024

Uh oh!

jaalah-akamai Mar 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hana-akamai commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dwiley-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

jaalah-akamai commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hana-akamai commented Mar 6, 2024

Uh oh!

jaalah-akamai Mar 7, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hana-akamai commented Feb 22, 2024 •

edited

Loading

github-actions bot commented Mar 5, 2024 •

edited

Loading

jaalah-akamai commented Mar 6, 2024 •

edited

Loading