upcoming: [M3-7874] - Linode Create Refactor - Marketplace - Part 1#10401
Merged
bnussman-akamai merged 5 commits intolinode:developfrom Apr 25, 2024
Conversation
bnussman-akamai
requested review from
abailly-akamai,
hkhalil-akamai and
jdamore-linode
and removed request for
a team
hkhalil-akamai
approved these changes
Apr 23, 2024
Contributor
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
There was a problem hiding this comment.
All for these short and sweet PRs! As long as it works for you
Comment on lines
+26
to
+34
| <Autocomplete | ||
| textFieldProps={{ | ||
| containerProps: { sx: { minWidth: 250 } }, | ||
| hideLabel: true, | ||
| }} | ||
| label="Select category" | ||
| options={categoryOptions} | ||
| placeholder="Select category" | ||
| /> |
Contributor
There was a problem hiding this comment.
Can we fix the slight height discrepancy that has always existed between these two inputs?
Member
Author
There was a problem hiding this comment.
I'll try taking a look, but if I can't figure it our cleanly, I'll make a ticket for this
| 'Security', | ||
| 'Stacks', | ||
| 'Website', | ||
| ]; |
Contributor
There was a problem hiding this comment.
Can we generate this dynamically by doing
const categories = oneClickApps.reduce((acc, app) => {
return [...acc, ...app.categories];
}, [] as string[]);
const uniqueCategories = [...new Set(categories)]or similar?
abailly-akamai
approved these changes
Apr 25, 2024
Contributor
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
Love the small PRs!
bnussman-akamai
added
Approved
|
Coverage Report: ✅ |
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Begins building out the Marketplace section of the new Linode Create flow 🏗️
Note
I'm going to trial to do small consumable PRs for the remainder of the Linode Create refactor. If these PRs seem too small, just let me know.
Preview 📷
How to test 🧪
Prerequisites
Linode Create v2feature flagVerification steps
As an Author I have considered 🤔