Skip to content

refactor: [M3-8043] - Query Key Factory for Volumes#10414

Merged
bnussman-akamai merged 4 commits intolinode:developfrom
bnussman-akamai:M3-8043-query-key-factory-volumes
Apr 30, 2024
Merged

refactor: [M3-8043] - Query Key Factory for Volumes#10414
bnussman-akamai merged 4 commits intolinode:developfrom
bnussman-akamai:M3-8043-query-key-factory-volumes

Conversation

@bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Apr 26, 2024

Description 📝

Refactors Volume Queries

Changes 🔄

Preview 📷

Note

No UI changes

How to test 🧪

  • Verify all Volume create, update, delete work the same as the previously did
  • Verify all automated testing for volumes pass

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added React Query Relating to the transition to use React Query Volumes Relating to Volumes (aka Block Storage) labels Apr 26, 2024
@bnussman-akamai bnussman-akamai self-assigned this Apr 26, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner April 26, 2024 21:43
@bnussman-akamai bnussman-akamai requested review from carrillo-erik and dwiley-akamai and removed request for a team April 26, 2024 21:43
@github-actions
Copy link

github-actions bot commented Apr 26, 2024

Coverage Report:
Base Coverage: 81.82%
Current Coverage: 81.82%

@bnussman-akamai bnussman-akamai requested a review from a team as a code owner April 29, 2024 03:28
@bnussman-akamai bnussman-akamai requested review from cliu-akamai and removed request for a team April 29, 2024 03:28
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality of volume operations ✅
Code review ✅
Tests passing ✅

@carrillo-erik
Copy link
Contributor

Manually tested the Volumes functionality across the application and did not experience any issues. No issues with C/I pipelines. Overall it's a good refactor of the existing queries that will serve as an example for future refactors using the query key factory pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

React Query Relating to the transition to use React Query Volumes Relating to Volumes (aka Block Storage)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants