test: [M3-8050] - Fix OBJ E2E tests following API release#10417
Merged
jdamore-linode merged 2 commits intolinode:developfrom Apr 30, 2024
Merged
test: [M3-8050] - Fix OBJ E2E tests following API release#10417jdamore-linode merged 2 commits intolinode:developfrom
jdamore-linode merged 2 commits intolinode:developfrom
Conversation
jdamore-linode
requested review from
cliu-akamai
and removed request for
a team
jdamore-linode
requested review from
cpathipa and
hkhalil-akamai
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Apr 29, 2024
cpathipa
approved these changes
Apr 30, 2024
Contributor
cpathipa
left a comment
cpathipa
left a comment
There was a problem hiding this comment.
Thank you @jdamore-linode for fixing it.
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This fixes a couple OBJ E2E tests that are failing following the latest API release. The failures are caused by the API responding with a
400when we pass theregionproperty in OBJ requests; previously this property was ignored, but now the API handles the property by rejecting it when a certain API-side config flag is not set.Our OBJ factories include values for both the
regionandclusterproperties, so this fixes the issue by manually settingregiontoundefinedin the impacted tests.How to test 🧪
We can rely on CI for this; in its current state, these two tests fail 100% of the time, so it should be pretty easy to determine whether or not this PR resolves the problem.
As an Author I have considered 🤔
Check all that apply