Skip to content

fix: [M3-7822] - Prevent Modification of Linode config 'interfaces' Array on No Changes#10423

Merged
cpathipa merged 3 commits intolinode:developfrom
cpathipa:M3-7822
May 7, 2024
Merged

fix: [M3-7822] - Prevent Modification of Linode config 'interfaces' Array on No Changes#10423
cpathipa merged 3 commits intolinode:developfrom
cpathipa:M3-7822

Conversation

@cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Apr 30, 2024

Description 📝

This PR prevents modifying the value of a Linode config's 'interfaces': [] with defaults in the payload when there are no changes made. Refer to the ticket for more details.

Target release date 🗓️

5/13

Preview 📷

image

How to test 🧪

Verification steps

(How to verify changes)

  • Create a linode.
  • Navigate to linode config and click on edit button.
  • Make no changes and click on save.
  • Observe the payload, there shouldn't be any override's to the interfaces array with defaults. (ex: if interfaces: [] it should stay like that and not be modified)
  • Ensure there is no regression for Add/ Edit and deleting configurations.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@cpathipa cpathipa requested a review from a team as a code owner April 30, 2024 19:07
@cpathipa cpathipa requested review from bnussman-akamai and mjac0bs and removed request for a team April 30, 2024 19:07
@cpathipa cpathipa marked this pull request as draft April 30, 2024 19:07
@cpathipa cpathipa marked this pull request as ready for review April 30, 2024 19:21
@cpathipa cpathipa self-assigned this Apr 30, 2024
@github-actions
Copy link

github-actions bot commented Apr 30, 2024

Coverage Report:
Base Coverage: 82.02%
Current Coverage: 82.02%

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix confirmed, no regressions observed ✅
Code review ✅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the previous logic was failing because of the presence of ip_ranges on the defaultInterface

Screenshot 2024-05-01 at 11 54 02 AM

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed a public interface in eth0 isn't sent in the interfaces list when a config is added or edited. Tested other interface combinations for regressions and confirmed those updated the interface list in the request as expected.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 1, 2024
@cpathipa cpathipa merged commit f636ab7 into linode:develop May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants