fix: [M3-8053] - Fix table component props forwarding#10424
Merged
abailly-akamai merged 3 commits intolinode:developfrom May 1, 2024
Merged
fix: [M3-8053] - Fix table component props forwarding#10424abailly-akamai merged 3 commits intolinode:developfrom
abailly-akamai merged 3 commits intolinode:developfrom
Conversation
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Apr 30, 2024
Member
bnussman-akamai
left a comment
There was a problem hiding this comment.
Looks good. Nice clean up too 🧼
hkhalil-akamai
approved these changes
Apr 30, 2024
Contributor
hkhalil-akamai
left a comment
There was a problem hiding this comment.
Thanks for the fix!
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This previous commit introduced an issue with classes meant for the table wrapper being passed to the table component.
Previously, we were using
lodashomit to remove props that were not even being passed, so it was useless. The good news is that my util is actually better typed than thelodashone so when i switched i was seeing typed errors trying to remove non-existing props.The fix: we only need to pass true table props to the actual Table component and keep the extra props for the wrapper.
Changes 🔄
TablecomponentPreview 📷
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply