Skip to content

fix: [M3-8053] - Fix table component props forwarding#10424

Merged
abailly-akamai merged 3 commits intolinode:developfrom
abailly-akamai:M3-8053
May 1, 2024
Merged

fix: [M3-8053] - Fix table component props forwarding#10424
abailly-akamai merged 3 commits intolinode:developfrom
abailly-akamai:M3-8053

Conversation

@abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Apr 30, 2024

Description 📝

This previous commit introduced an issue with classes meant for the table wrapper being passed to the table component.

Previously, we were using lodash omit to remove props that were not even being passed, so it was useless. The good news is that my util is actually better typed than the lodash one so when i switched i was seeing typed errors trying to remove non-existing props.

The fix: we only need to pass true table props to the actual Table component and keep the extra props for the wrapper.

Changes 🔄

  • prevent forwarding non table props to the Table component

Preview 📷

Before After
Screen Shot 2024-04-30 at 15 19 12 Screen Shot 2024-04-30 at 15 23 48

How to test 🧪

Verification steps

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@abailly-akamai abailly-akamai self-assigned this Apr 30, 2024
@abailly-akamai abailly-akamai marked this pull request as ready for review April 30, 2024 19:29
@abailly-akamai abailly-akamai requested a review from a team as a code owner April 30, 2024 19:29
@abailly-akamai abailly-akamai requested review from cpathipa and hkhalil-akamai and removed request for a team April 30, 2024 19:29
@abailly-akamai abailly-akamai changed the title fix: [M3-8053] - Fix table wrapper small visual regression fix: [M3-8053] - Fix table component props forwarding Apr 30, 2024
@github-actions
Copy link

Coverage Report:
Base Coverage: 81.82%
Current Coverage: 81.82%

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice clean up too 🧼

Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants