change: Remove semver bump in generate-changelogs.mjs#10426
Merged
hkhalil-akamai merged 2 commits intolinode:developfrom May 1, 2024
Merged
change: Remove semver bump in generate-changelogs.mjs#10426hkhalil-akamai merged 2 commits intolinode:developfrom
generate-changelogs.mjs#10426hkhalil-akamai merged 2 commits intolinode:developfrom
Conversation
hkhalil-akamai
requested review from
carrillo-erik and
jdamore-linode
and removed request for
a team
hkhalil-akamai
commented
Apr 30, 2024
|
|
||
| // Delete the changeset files for each package | ||
| deleteChangesets(linodePackage); | ||
| await deleteChangesets(linodePackage); |
Contributor
Author
There was a problem hiding this comment.
This prevents the "Deleted" logs from writing over the prompt
|
Coverage Report: ✅ |
jdamore-linode
approved these changes
May 1, 2024
Contributor
jdamore-linode
left a comment
jdamore-linode
left a comment
There was a problem hiding this comment.
Nice! Confirmed changelog generation still works but the version isn't getting bumped. Thanks @hkhalil-akamai
abailly-akamai
approved these changes
May 1, 2024
Contributor
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
Nice thanks for fixing!
I don't think we need a changeset for this?
|
|
||
| // Delete the changeset files for each package | ||
| deleteChangesets(linodePackage); | ||
| await deleteChangesets(linodePackage); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Based on a cafe discussion, remove the semver bump in
generate-changelogs.mjssince those are handled in a different step in the release process.How to test 🧪
yarn generate-changelogs