refactor: [M3-8059] - Clean up Main Content Banner#10430
Merged
bnussman-akamai merged 3 commits intolinode:developfrom May 3, 2024
Merged
refactor: [M3-8059] - Clean up Main Content Banner#10430bnussman-akamai merged 3 commits intolinode:developfrom
bnussman-akamai merged 3 commits intolinode:developfrom
Conversation
bnussman-akamai
commented
May 1, 2024
Member
Author
There was a problem hiding this comment.
The diff is kind of crazy. The only significant changes here are:
- Remove extra util functions 🗑️
- Move position of
<MainContentBanner />
|
Coverage Report: ✅ |
jaalah-akamai
approved these changes
May 2, 2024
cpathipa
approved these changes
May 3, 2024
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Refactors the
MainContentBannerto be simpler, clean, and self-contained 🧹(I'm doing this because I want to clean up and attempt to improve performance
index.tsx,App.tsx, andMainContent.tsx)Changes 🔄
MainContent.tsx🗑️Preview 📷
Warning
I did make minor UI changes to the banner in efforts to simplify the styles
How to test 🧪
MainContentBanner.tsxyou can use to test the banner 🏴As an Author I have considered 🤔