Skip to content

test: Fix Placement Group delete tests following wording improvement#10432

Merged
jdamore-linode merged 1 commit intolinode:developfrom
jdamore-linode:fix-vmpg-delete-test-language
May 2, 2024
Merged

test: Fix Placement Group delete tests following wording improvement#10432
jdamore-linode merged 1 commit intolinode:developfrom
jdamore-linode:fix-vmpg-delete-test-language

Conversation

@jdamore-linode
Copy link
Contributor

Description 📝

Quick fix for the VMPG delete failures -- the wording on the toast notification was improved, but on a branch that didn't have these tests, so the tests began failing when they were merged.

(Don't think a changeset is even necessary here since these tests haven't been released yet -- any other thoughts?)

How to test 🧪

CI's good enough here.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode self-assigned this May 2, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 2, 2024 15:06
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team May 2, 2024 15:07
@github-actions
Copy link

github-actions bot commented May 2, 2024

Coverage Report:
Base Coverage: 81.82%
Current Coverage: 81.82%

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 2, 2024
@jdamore-linode jdamore-linode merged commit df186a8 into linode:develop May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants