upcoming: [M3-8025] - Placement Groups: Allow null for maximum_pgs_per_customer

[abailly-akamai]

Description 📝

maximum_pgs_per_customer: This value can be unlimited for some customers in some regions, for which the API returns the null value. The UI representation of this null value is the "unlimited" string

Changes 🔄

• Allow null for maximum_pgs_per_customer in APIv4
• Add new util to return the proper limit in the UI

Target release date 🗓️

5/13/2024

Preview 📷

How to test 🧪

Verification steps

ℹ️ have both the "Placement Group" feature flag and MSW on

• Navigate to http://localhost:3000/placement-groups/create
• Pick Toronto as the region
• Notice the helper text

As an Author I have considered 🤔

Check all that apply

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[github-actions]

Coverage Report: ✅
Base Coverage: 81.82%
Current Coverage: 81.82%

[mjac0bs]

The code and test coverage makes sense, so approving so as to make sure it gets in the upcoming release. I'm not a big fan of the text wrapping and way that unlimited is isolated on a line by itself, which makes it not very scannable and seem out of place.

I don't know that breaking the helper text earlier on that line would improve things, though, so maybe the lonely 'unlimited' is the best we can do, short of rendering a different sentence for the unlimited case, and my guess is that UX considered that and opted not to.

[abailly-akamai]

@mjac0bs i completely agree - i made an executive decision to shorten that sentence which was too verbose anyway. (screenshot updated)

[carrillo-erik]

Looks good to me. I was able to verify that the Toronto region will display unlimited and compared to New Jersey which has a limit of 5 Placement Groups.