upcoming: [M3-7690] - Support PlacementGroups in CLI tool#10438
Merged
abailly-akamai merged 2 commits intolinode:developfrom May 7, 2024
Merged
upcoming: [M3-7690] - Support PlacementGroups in CLI tool#10438abailly-akamai merged 2 commits intolinode:developfrom
abailly-akamai merged 2 commits intolinode:developfrom
Conversation
carrillo-erik
requested review from
abailly-akamai,
dwiley-akamai and
mjac0bs
and removed request for
a team
carrillo-erik
commented
May 3, 2024
| acc.push(` --${key}.user_data="${userData.user_data}"`); | ||
| } else if (key === 'placement_group') { | ||
| const placementGroup = value as PlacementGroup; | ||
| acc.push(` --${key}.id ${placementGroup.id}`); |
Contributor
Author
There was a problem hiding this comment.
This line could also be written as
acc.push(` --${key}.id="${placementGroup.id}"`);
Will need to check with DX team to ensure the correct formatting is applied to the placement_group.id argument.
👀root_pass values in the CLI Modal images because these instances were never created and used only to show the difference in output of the placement_group.id value.
carrillo-erik
commented
May 3, 2024
| --authorized_users Gritty \\ | ||
| --interfaces.ipam_address null --interfaces.ipv4.nat_1_1 \"any\" --interfaces.ipv4.vpc \"123\" --interfaces.label null --interfaces.primary true --interfaces.purpose \"vpc\" --interfaces.subnet_id 8296 \\ | ||
| --metadata.user_data="cmVrbmpnYmloZXVma2xkbQpqZXZia2Y=" \\ | ||
| --placement_group.id 1234 \\ |
Contributor
Author
There was a problem hiding this comment.
This is tied to the comment on the other comment below, placement_group.id is expected to be an int and should not require " " marks around the value. Only string type values take " " marks.
|
Coverage Report: ✅ |
Contributor
|
we need a review from @lgarber-akamai |
dwiley-akamai
approved these changes
May 6, 2024
abailly-akamai
approved these changes
May 7, 2024
This was referenced May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR allows Placement Group data to be passed in as arguments via the
Linode CLI.Changes 🔄
idvalue. In the end the relevant argument and value are passed as follows:placement_group.id 1234.Target release date 🗓️
05/13/2024
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
linode-clitool.As an Author I have considered 🤔
Check all that apply