Skip to content

test: [M3-7772] - Add Cypress integration test for Placement Group create flow#10445

Merged
jdamore-linode merged 3 commits intolinode:developfrom
jdamore-linode:M3-7772-vmpg-create-integration-tests
May 9, 2024
Merged

test: [M3-7772] - Add Cypress integration test for Placement Group create flow#10445
jdamore-linode merged 3 commits intolinode:developfrom
jdamore-linode:M3-7772-vmpg-create-integration-tests

Conversation

@jdamore-linode
Copy link
Contributor

Description 📝

Adds a Cypress integration test for basic Placement Group create flow. It confirms that a Placement Group can be created from the landing page, that the outgoing API request contains the expected payload, and that Cloud responds as expected by showing a toast and updating its content upon successful Placement Group creation.

Changes 🔄

  • Adds PG create test in cypress/e2e/core/placementGroups/create-placement-groups.spec.ts
  • Adds PG create mock util

How to test 🧪

yarn && yarn build && yarn start:manager:ci, and then:

yarn cy:run -s "cypress/e2e/core/placementGroups/create-placement-groups.spec.ts"

Alternatively, you can run the test via yarn cy:debug.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode self-assigned this May 7, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 7, 2024 18:03
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team May 7, 2024 18:03
@github-actions
Copy link

github-actions bot commented May 7, 2024

Coverage Report:
Base Coverage: 82.01%
Current Coverage: 82.01%

@jdamore-linode jdamore-linode requested a review from a team as a code owner May 8, 2024 19:46
@jdamore-linode jdamore-linode requested review from abailly-akamai and dwiley-akamai and removed request for a team May 8, 2024 19:46
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes ✅
Code review ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants