Skip to content

Conversation

@jdamore-linode
Copy link
Contributor

Description 📝

Adds a test to confirm the populated state of the Placement Group landing page. Specifically, confirms that each Placement Group is listed as expected and that non-compliance indicator is present when necessary (and absent otherwise).

Changes 🔄

  • Adds Placement Group populated landing page test
  • Adds a mock util that will be necessary but didn't actually get used

How to test 🧪

yarn cy:run -s "cypress/e2e/core/placementGroups/placement-groups-landing-page.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode self-assigned this May 7, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 7, 2024 19:16
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team May 7, 2024 19:16
@github-actions
Copy link

github-actions bot commented May 7, 2024

Coverage Report:
Base Coverage: 82%
Current Coverage: 82%

@jdamore-linode jdamore-linode requested a review from a team as a code owner May 8, 2024 19:45
@jdamore-linode jdamore-linode requested review from carrillo-erik and cpathipa and removed request for a team May 8, 2024 19:45
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants