Skip to content

test: [M3-8088] - Fix One-Click App test failure by using Ubuntu 22.04 image#10447

Merged
jdamore-linode merged 2 commits intolinode:developfrom
jdamore-linode:fix-oca-deploy-test
May 8, 2024
Merged

test: [M3-8088] - Fix One-Click App test failure by using Ubuntu 22.04 image#10447
jdamore-linode merged 2 commits intolinode:developfrom
jdamore-linode:fix-oca-deploy-test

Conversation

@jdamore-linode
Copy link
Contributor

Description 📝

Fixes a test failure in one-click-apps.spec.ts stemming from a backend update made to the Minecraft app earlier today. The backend change made the app compatible only with Ubuntu 22.04, and this test attempts to deploy using Ubuntu 20.04, leading to the failure.

This is a really quick fix to get the test passing again, but wrote up M3-8089 to revisit this test and eliminate the risk of this type of issue happening again.

Changes 🔄

  • Fixes failure by replacing Ubuntu 20.04 with Ubuntu 22.04

How to test 🧪

We can rely on CI for this one.

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode self-assigned this May 8, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 8, 2024 17:44
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team May 8, 2024 17:44
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 8, 2024 17:47
@jdamore-linode jdamore-linode requested review from hkhalil-akamai and mjac0bs and removed request for a team May 8, 2024 17:47
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Thanks, Joe!

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 8, 2024
@github-actions
Copy link

github-actions bot commented May 8, 2024

Coverage Report:
Base Coverage: 82.01%
Current Coverage: 82.01%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants