Skip to content

Conversation

@jdamore-linode
Copy link
Contributor

Description 📝

Adds a handful of Cypress integration tests for Placement Group Linode assignment flows.

  • Confirms that Linodes can be assigned to Placement Group
  • Confirms UI behavior when assigning a Linode that puts a weakly-enforced Placement Group into non-compliance
  • Confirms UI behavior when attempting to assign a Linode that would put a strictly-enforced Placement Group into non-compliance
  • Confirms that Linodes can be unassigned from Placement Group via its details page

Changes 🔄

  • Adds assignment tests in cypress/e2e/core/placementGroups/placement-groups-linode-assignment.spec.ts
  • Adds a couple Placement Group intercept utils in cypress/support/intercepts/placement-groups.ts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/placementGroups/placement-groups-linode-assignment.spec.ts"

Alternatively, you can run the tests interactively with yarn cy:debug

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode requested a review from a team as a code owner May 8, 2024 19:33
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team May 8, 2024 19:33
@jdamore-linode jdamore-linode self-assigned this May 8, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 8, 2024 19:35
@jdamore-linode jdamore-linode requested review from bnussman-akamai and hana-akamai and removed request for a team May 8, 2024 19:35
@github-actions
Copy link

github-actions bot commented May 8, 2024

Coverage Report:
Base Coverage: 82.01%
Current Coverage: 82.01%

Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all tests passed ✅
image

@hana-akamai hana-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Add'tl Approval Needed Waiting on another approval! Placement Groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants