refactor: [M3-7441] - Clean up NodeBalancer Firewall Feature Flag #10460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
cpathipa and
dwiley-akamai
and removed request for
a team
|
Coverage Report: ✅ |
dwiley-akamai
approved these changes
May 15, 2024
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
No adverse effects observed in NodeBalancer & Firewall flows ✅
Code review ✅
bnussman-akamai
added
Add'tl Approval Needed
abailly-akamai
approved these changes
May 16, 2024
Contributor
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
packages/manager/src/features/Firewalls/FirewallDetail/Devices/FirewallDeviceLanding.tsx
Outdated
Show resolved
Hide resolved
…/FirewallDeviceLanding.tsx Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com>
mjac0bs
added
Approved
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
firewallNodebalancer) because this feature has been out for a while 🧹🧱🔥Preview 📷
Note
No UI changes expected
How to test 🧪
As an Author I have considered 🤔