Skip to content

Conversation

@bnussman-akamai
Copy link
Member

Description 📝

  • Updates Storybook to latest ⬆️

Significant Changes

How to test 🧪

  • Verify Storybook works as expected locally
  • Verify Storybook build works (see Github Actions)

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added Dependencies Pull requests that update a dependency file Storybook labels May 14, 2024
@bnussman-akamai bnussman-akamai self-assigned this May 14, 2024
@bnussman-akamai bnussman-akamai marked this pull request as ready for review May 14, 2024 15:13
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner May 14, 2024 15:13
@bnussman-akamai bnussman-akamai requested review from abailly-akamai, hkhalil-akamai and mjac0bs and removed request for a team May 14, 2024 15:13
Copy link
Contributor

@hkhalil-akamai hkhalil-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and storybook is looking good! Curious as to why the changes to some of the component stories were required -- was it a breaking change in storybook?

@bnussman-akamai
Copy link
Member Author

I think there was a breaking change with the TypeScript types specifically @hkhalil-akamai

@jdamore-linode jdamore-linode self-requested a review May 14, 2024 16:27
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bnussman-akamai! Storybook seems to be working as expected with the updated packages, and I confirmed that the test failures can be disregarded 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file Storybook

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants