Skip to content

Conversation

@jdamore-linode
Copy link
Contributor

Description 📝

Quick clean up to replace calls to cy.intercept with utils in our support ticket create test.

Changes 🔄

  • Replace calls to cy.intercept with mock utils in open-support-ticket.spec.ts.
  • Adds mockAttachSupportTicketFile() util

How to test 🧪

We can rely on CI to confirm that this test has not been broken by these changes, but to run the test locally you can use this command:

yarn cy:run -s "cypress/e2e/core/helpAndSupport/open-support-ticket.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode requested a review from AzureLatte May 14, 2024 15:56
@jdamore-linode jdamore-linode self-assigned this May 14, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 14, 2024 15:56
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team May 14, 2024 15:56
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 14, 2024 15:57
@jdamore-linode jdamore-linode requested review from abailly-akamai and bnussman-akamai and removed request for a team May 14, 2024 15:57
@github-actions
Copy link

github-actions bot commented May 14, 2024

Coverage Report:
Base Coverage: 82.01%
Current Coverage: 82.01%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Code looks good ✅
Both tests passing as expected ✅

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 15, 2024
@jdamore-linode jdamore-linode merged commit 1e4a9a0 into linode:develop May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants