Skip to content

Conversation

@jdamore-linode
Copy link
Contributor

@jdamore-linode jdamore-linode commented May 14, 2024

Description 📝

Quick fix for the StackScript test that began failing today because Fedora 38 got marked as deprecated. Also opened M3-8098 to improve this test's resilience to backend Image changes.

Changes 🔄

  • Use up-to-date Images in StackScript test

How to test 🧪

We can rely on CI for this, but to run the test locally you can use this command:

yarn cy:run -s "cypress/e2e/core/stackscripts/create-stackscripts.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@jdamore-linode jdamore-linode self-assigned this May 14, 2024
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 14, 2024 20:43
@jdamore-linode jdamore-linode requested review from cliu-akamai and removed request for a team May 14, 2024 20:43
@jdamore-linode jdamore-linode requested a review from a team as a code owner May 14, 2024 20:45
@jdamore-linode jdamore-linode requested review from bnussman-akamai and hana-akamai and removed request for a team May 14, 2024 20:45
@github-actions
Copy link

github-actions bot commented May 14, 2024

Coverage Report:
Base Coverage: 82.01%
Current Coverage: 82.01%

Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turn around 🥇

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the follow up ticket! 🧪 🚢

Screenshot 2024-05-15 at 8 00 00 AM

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 15, 2024
@jdamore-linode jdamore-linode merged commit d344b75 into linode:develop May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants