Skip to content

Conversation

@AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented May 16, 2024

Description 📝

Clean up cy.intercept calls in smoke-delete-linode

Changes 🔄

List any change relevant to the reviewer.

  • Replace calls to cy.intercept with intercept utils in linodes.ts and account.ts
  • Adds interceptDeleteLinode() util

How to test 🧪

We can rely on CI to confirm that this test has not been broken by these changes, but to run the test locally you can use this command:

yarn cy:run -s "cypress/e2e/core/linodes/smoke-delete-linode.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte requested review from a team May 16, 2024 16:16
@AzureLatte AzureLatte self-assigned this May 16, 2024
@AzureLatte AzureLatte requested review from abailly-akamai, cliu-akamai and mjac0bs and removed request for a team May 16, 2024 16:16
@AzureLatte AzureLatte requested review from a team as code owners May 16, 2024 16:17
@AzureLatte AzureLatte requested review from dwiley-akamai, hana-akamai and jdamore-linode and removed request for a team May 16, 2024 16:17
@github-actions
Copy link

github-actions bot commented May 16, 2024

Coverage Report:
Base Coverage: 82.01%
Current Coverage: 82.01%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

image

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 16, 2024
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @AzureLatte!

@AzureLatte AzureLatte merged commit 65bbed1 into linode:develop May 16, 2024
@AzureLatte AzureLatte deleted the M3-8106-refactor-linode-delete-test-intercepts branch May 16, 2024 20:16
@AzureLatte AzureLatte added Clean Up and removed Approved Multiple approvals and ready to merge! labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants