refactor: [M3-8097] - Retire recharts feature flag #10483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
commented
May 17, 2024
| } | ||
|
|
||
| // @todo recharts: delete this file when we decide recharts is stable (new version is AccessibleAreaChart) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
we can't really delete it because LineCharts is till being used in longview (only place after this PR)
Contributor
There was a problem hiding this comment.
Agreed, we should keep some kind of comment as a reminder to remove this though
abailly-akamai
requested review from
hkhalil-akamai and
jaalah-akamai
and removed request for
a team
|
Coverage Report: ✅ |
jaalah-akamai
approved these changes
May 17, 2024
hana-akamai
approved these changes
May 17, 2024
| } | ||
|
|
||
| // @todo recharts: delete this file when we decide recharts is stable (new version is AccessibleAreaChart) | ||
|
|
Contributor
There was a problem hiding this comment.
Agreed, we should keep some kind of comment as a reminder to remove this though
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR gets rid of the recharts feature flag in order to remove heavy dependencies we're shipping to our users in the Linode detail flow.
charts.jsmoment,js(which is a dpendency of the above)It cleans up conditional rendering of the old charts since everything has been stable since the new charts have been released.
Only remaining components using charts.js:
GaugePercentLineGraphwhich are both only for longview 🎉
🥇 Thanks @hana-linode for the super clean handling of splitting the feature initially, was very easy to clean up
Changes 🔄
Preview 📷
No visual change expected as part of this PR
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply