-
Notifications
You must be signed in to change notification settings - Fork 392
refactor: [M3-8045] - remove aria-label from TableRow #10485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Coverage Report: ✅ |
hana-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing a search for ariaLabel in the codebase, would the StatusIcon and StyledStatusIcon components be a good contender for removal as well since they aren't interactive?
dwiley-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review ✅
Tests pass ✅
packages/manager/src/components/CollapsibleTable/CollapsibleTable.tsx
Outdated
Show resolved
Hide resolved
|
@hana-linode yup! adding those to my epic, thanks for pointing it out |
Description 📝
While aria-label can be used on any element that can have an accessible name, in practice however, it is supported only on interactive elements, widgets, landmarks, images, and iframes.
While aria-label can be used on any element that has an accessible name, it's best supported for interactive elements, widgets, landmarks, images, and iframes. In general, it shouldn't be used on static content. Using aria-label on non-interactive elements can cause a confusing user experience or the label may not be announced by assistive technology. For example, Microsoft's screen reader, JAWS, ignores aria-label on all static content except for content with “an interactive role, img role, or nav, main, search roles”.
also: https://stackoverflow.com/questions/72568204/what-can-aria-label-be-used-on
In the case of our table rows, having an aria label dos not really make sense:
Changes 🔄
ariaLabelon<TableRow />Preview 📷
No visual changes should be expected as part of this PR
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply