removed: [M3-7554, M3-7559] - Post Release Cleanup Parent/Child Feature Flags #10489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaalah-akamai
requested review from
AzureLatte,
abailly-akamai and
mjac0bs
and removed request for
a team
jaalah-akamai
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| it('cannot edit billing information with read-only account access', () => { | ||
| const mockProfile = profileFactory.build({ | ||
| username: randomLabel(), |
Check failure
Code scanning / CodeQL
Insecure randomness
| */ | ||
| it('cannot edit billing information as child account', () => { | ||
| const mockProfile = profileFactory.build({ | ||
| username: randomLabel(), |
Check failure
Code scanning / CodeQL
Insecure randomness
| */ | ||
| it('can edit billing information as a regular user and as a parent user', () => { | ||
| const mockProfileRegular = profileFactory.build({ | ||
| username: randomLabel(), |
Check failure
Code scanning / CodeQL
Insecure randomness
| ` Please contact your ${PARENT_USER} to request the necessary permissions.` | ||
| ); | ||
| const mockProfileParent = profileFactory.build({ | ||
| username: randomLabel(), |
Check failure
Code scanning / CodeQL
Insecure randomness
|
Coverage Report: ✅ |
mjac0bs
approved these changes
May 20, 2024
Contributor
There was a problem hiding this comment.
Thanks for removing the flag. It is done! 🎉
- Code looks good with removal of flag.
- Manually confirmed that parent (unrestricted and restricted), proxy, and child account basic flows to confirm users had expected enabled/disabled states and things like API tokens are being created correctly. Did not see any regressions.
- Confirmed default accounts don't see account switching UI components.
- Confirmed account switching is still working as expected.
- Confirmed the feature flag is no longer present in our dev tools.
- Confirmed relevant tests pass - the one failure in CI is an unrelated create-stackscripts test which was failing last week and fixed... this branch might not have been created off the latest
develop.
| "@linode/manager": Removed | ||
| --- | ||
|
|
||
| Post release cleanup of parent/child feature flags ([#10489](https://github.com/linode/manager/pull/10489)) |
Contributor
There was a problem hiding this comment.
Suggested change
| Post release cleanup of parent/child feature flags ([#10489](https://github.com/linode/manager/pull/10489)) | |
| `parentChildAccountAccess` feature flag ([#10489](https://github.com/linode/manager/pull/10489)) |
Contributor
|
@jaalah-akamai any reason why this contribution is not coming from your fork? |
Contributor
Author
|
See: #10497 |
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Remove the
parentChildAccountAccessfeature flag logic now that the feature has been in production for some time.Changes 🔄
Target release date 🗓️
Next release: 5/28
How to test 🧪
Prerequisites
Verification steps
yarn testAs an Author I have considered 🤔
Check all that apply
Commit message and pull request title format standards
<commit type>: [JIRA-ticket-number] - <description>Commit Types:
feat: New feature for the user (not a part of the code, or ci, ...).fix: Bugfix for the user (not a fix to build something, ...).change: Modifying an existing visual UI instance. Such as a component or a feature.refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.test: New tests or changes to existing tests. Does not change the production code.upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.Example:
feat: [M3-1234] - Allow user to view their login history