Skip to content

Conversation

@AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented May 21, 2024

Description 📝

Add new tests/assertions to check error handling in delete-placement-groups.spec.ts.
Confirm that Cloud Manager gracefully responds if an API error occurs while un-assigning a Linode via the delete modal.
Confirm that Cloud Manager gracefully responds if an API error occurs upon attempt to delete a VM Placement Group.

Changes 🔄

  • Add new assertion to check user can retry and continue with deletion when unexpected error happens.
  • Add new test to check that user can close and reopen the dialog when unexpected error happens during deletion. (skipped due to M3-8112)
  • Add new assertion to check user can retry and continue with unassignment when unexpected error happens.
  • Add new test to check that user can close and reopen the dialog when unexpected error happens during unassignment. (skipped due to M3-8112)

How to test 🧪

yarn cy:run -s "cypress/e2e/core/placementGroups/delete-placement-groups.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte requested review from a team May 21, 2024 13:25
@AzureLatte AzureLatte self-assigned this May 21, 2024
@AzureLatte AzureLatte requested review from hkhalil-akamai, jaalah-akamai and jdamore-linode and removed request for a team May 21, 2024 13:25
@AzureLatte AzureLatte requested review from a team as code owners May 21, 2024 14:24
@AzureLatte AzureLatte requested review from abailly-akamai, cliu-akamai and hana-akamai and removed request for a team May 21, 2024 14:24
Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Screenshot 2024-05-21 at 11 02 48 AM

@github-actions
Copy link

github-actions bot commented May 21, 2024

Coverage Report:
Base Coverage: 81.62%
Current Coverage: 81.62%

@abailly-akamai
Copy link
Contributor

@AzureLatte you will need to rebase this PR with the latest develop. All tests are failing now because of a bad merge that ended up in develop.

@AzureLatte
Copy link
Contributor Author

@AzureLatte you will need to rebase this PR with the latest develop. All tests are failing now because of a bad merge that ended up in develop.

Just updated. Could you please retry? Thank you!

@abailly-akamai
Copy link
Contributor

@AzureLatte #10486 was merged!

you should be able to remove this skip in this PR now

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @AzureLatte, tests look great and bonus points for catching that dialog reset issue too!

Also confirmed that pulling in the latest changes from develop allows those skipped tests to pass 👍 approved pending the latest from develop getting merged in and those tests being unskipped!

@jdamore-linode jdamore-linode added Approved Multiple approvals and ready to merge! and removed Ready for Review labels May 21, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the coverage and reporting that bug! 🚢

@AzureLatte AzureLatte merged commit 0b0cf98 into linode:develop May 22, 2024
@AzureLatte AzureLatte deleted the M3-7783-add-cypress-assertion-for-placement-group-deletion-error-handling branch May 22, 2024 15:23
@AzureLatte AzureLatte added e2e Indicates that a PR touches Cypress tests in some way and removed Approved Multiple approvals and ready to merge! labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Indicates that a PR touches Cypress tests in some way

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants