-
Notifications
You must be signed in to change notification settings - Fork 392
test: [M3-7783] Add cypress assertion and test for placement group deletion error handling #10493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-7783] Add cypress assertion and test for placement group deletion error handling #10493
Conversation
…groups and skip tests due to bug ticket M3-8112
jaalah-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Coverage Report: ✅ |
|
@AzureLatte you will need to rebase this PR with the latest develop. All tests are failing now because of a bad merge that ended up in develop. |
…nt-group-deletion-error-handling
…eletion error handling
Just updated. Could you please retry? Thank you! |
|
@AzureLatte #10486 was merged! you should be able to remove this skip in this PR now |
jdamore-linode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @AzureLatte, tests look great and bonus points for catching that dialog reset issue too!
Also confirmed that pulling in the latest changes from develop allows those skipped tests to pass 👍 approved pending the latest from develop getting merged in and those tests being unskipped!
…nt-group-deletion-error-handling
abailly-akamai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for the coverage and reporting that bug! 🚢

Description 📝
Add new tests/assertions to check error handling in delete-placement-groups.spec.ts.
Confirm that Cloud Manager gracefully responds if an API error occurs while un-assigning a Linode via the delete modal.
Confirm that Cloud Manager gracefully responds if an API error occurs upon attempt to delete a VM Placement Group.
Changes 🔄
How to test 🧪
As an Author I have considered 🤔
Check all that apply