fix: [M3-8124] - RegionSelect unexpected keyboard behavior
#10495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested review from
AzureLatte and
carrillo-erik
and removed request for
a team
bnussman-akamai
commented
May 21, 2024
Comment on lines
-115
to
-120
| onKeyDown={(e) => { | ||
| if (e.key !== 'Tab') { | ||
| setSelectedRegion(null); | ||
| handleRegionChange(null); | ||
| } | ||
| }} |
Member
Author
There was a problem hiding this comment.
I'm curious about the original intention of this. Might warrant further discussion
Contributor
There was a problem hiding this comment.
If i remember well i had this in place cause a tab keydown would clear the select, but that's not something i can reproduce at all, so i am frankly doubting my sanity doing something like this - should've commented why.
Long story short, thx for fixing
|
Coverage Report: ✅ |
abailly-akamai
approved these changes
May 21, 2024
Contributor
abailly-akamai
left a comment
abailly-akamai
left a comment
There was a problem hiding this comment.
This is much better, thx for fixing
jaalah-akamai
approved these changes
May 22, 2024
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Removes one-off
onKeyDownlogic from theRegionSelectto fix unexpected keyboard behavior ⌨️Behavior Before this PR ❌
Behavior After this PR ✅
How to test 🧪
As an Author I have considered 🤔