upcoming: [M3-8217] - Tax Id Notifications & Icon

[jaalah-akamai]

Description 📝

New notifications for Tax Id

Changes 🔄

• Add two new notifications when tax id is valid/invalid
• Add warning icon next to tax id in billing section
  • Changed icon to solid variant for visibility (only used in this location in the app)

Target release date 🗓️

7/8

Preview 📷

worked.mov

Desc	SS
Notifications
Toast
Event

Icon Before	Icon After (ignore dark mode color changes)

How to test 🧪

Prerequisites

• If you want to test the events part of this, you'll need to setup DevEnv (see me about details)
• Otherwise, you can locally comment out the rendering conditions for the TooltipIcon

Validation

• Checkout this branch in devenv
• Checkout latest develop branch of apinext in devenv
• Add a row to the TaxValidation table with format_valid set to 1, and tax_registered to yes.
• curl /account/notifications and notice the tax_id_valid notification.
• Set format_valid to 0, and curl /account/notifications again, notice tax_id_invalid notification. Try again with format_valid set to 1, and tax_registered set to no.

Related

• fix: [M3-8342] - Toast Notifications for Images  #10664

[hkhalil-akamai]

I don't have devenv set up but I mocked the notification locally and verified the notification and tooltip appear as expected and display the tax id warning.

[github-actions]

Coverage Report: ✅
Base Coverage: 82.31%
Current Coverage: 82.31%

[jaalah-akamai]

I need to fix some invalidation issues with RQ - please hold

[jaalah-akamai]

Devenv has been having issues all day preventing me from e2e testing this - I will wait until things are back up and re-request reviews.

[bnussman-akamai]

Just a thought 💡

It might be a really nice UX to add toast notifications in packages/manager/src/hooks/useToastNotifications.tsx

[bnussman-akamai]

React Query and event handler changes look great ✅