feat: [M3-7684] - Disable Volume Action Menu Buttons for Restricted Users#10641
Merged
pmakode-akamai merged 4 commits intolinode:developfrom Jul 8, 2024
Conversation
|
Coverage Report: ✅ |
jaalah-akamai
approved these changes
Jul 3, 2024
55097c9 to
5a81d35
Compare
dwiley-akamai
approved these changes
Jul 5, 2024
Contributor
dwiley-akamai
left a comment
There was a problem hiding this comment.
Disabled Volume action menu buttons (edit, resize, clone, detach, delete) for users with read-only permissions ✅
Disabled delete action menu shows a restricted action notice if a Linode is attached ✅
(verified the above for both the Volumes landing page and Linode Details > Storage > Volumes table)
Code review ✅
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.
Here, we are disabling Volume Action Menu buttons when they do not have access or have read-only access.
Changes 🔄
read-onlyaccess. Otherwise, it will show a restricted action notice if a Linode is attached.Target release date 🗓️
July 8th, 2024
Preview 📷
Before_readonly_user_unattached_linode

After_readonly_user_unattached_linode.mov
Before_readonly_user_attached_linode.mov
After_readonly_user_attached_linode.mov
Note:
Read-Writeuser access is same Before and After (Delete tooltip will show a restricted action notice if a Linode is attached)Before_and_After_readwrite_user_attached_linode.mov
How to test 🧪
Prerequisites
(How to setup test environment)
- Start with
Read Onlyfor everythingReproduction steps
- Action Menu buttons will be disabled and will display their own corresponding tooltiptext notice message.
Verification steps
As an Author I have considered 🤔
Check all that apply