refactor: [M3-8285] - Improve getQueryParamsFromQueryString type safety#10645
Merged
hana-akamai merged 5 commits intolinode:developfrom Jul 10, 2024
Conversation
hana-akamai
commented
Jul 3, 2024
| super(props); | ||
|
|
||
| /** Get the query params as an object, excluding the "?" */ | ||
| const queryParams = getQueryParamsFromQueryString<LinodeCreateQueryParams>( |
Contributor
Author
There was a problem hiding this comment.
This was the change, everything else was basically ESLint
| /* Language and Environment */ | ||
| "jsx": "react", | ||
| "lib": ["dom", "es2020"], | ||
| "lib": ["dom", "dom.iterable", "es2020"], |
hana-akamai
requested review from
cpathipa,
jaalah-akamai and
jdamore-linode
and removed request for
a team
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Jul 9, 2024
bnussman-akamai
added
Add'tl Approval Needed
jaalah-akamai
approved these changes
Jul 10, 2024
hana-akamai
added
Approved
hana-akamai
deleted the
M3-8285-improve-getQueryParamsFromQueryString-type
branch
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Follow up to @jaalah's comment in #10479 about improving the type safety of getQueryParamsFromQueryString and removing the casting. The big diff is mostly from ESLint shuffling imports and code around
Changes 🔄
List any change relevant to the reviewer.
getQueryParamsFromQueryStringdom.iterableto tsconfig.jsonHow to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply