feat:[M3-8330] - Improve API flexibility for useToastNotification#10654
Merged
jaalah-akamai merged 5 commits intolinode:developfrom Jul 9, 2024
Merged
feat:[M3-8330] - Improve API flexibility for useToastNotification#10654jaalah-akamai merged 5 commits intolinode:developfrom
jaalah-akamai merged 5 commits intolinode:developfrom
Conversation
|
Coverage Report: ✅ |
Contributor
Author
|
@bnussman-akamai Good suggestions - let me know if there's anything else |
abailly-akamai
approved these changes
Jul 9, 2024
Contributor
abailly-akamai
left a comment
There was a problem hiding this comment.
Change makes sense! Confirming the toast status inversion ✅
will take this into consideration when getting to this refactor for the Events V2 epic
| )} | ||
| {link && <> {link}</>} | ||
| </> | ||
| ); |
Contributor
There was a problem hiding this comment.
FWI this isn't going to remain as such when I get to this part of the event refactor. We are going to use event factories to display these messages to it's centralized and consistent.
bnussman-akamai
approved these changes
Jul 9, 2024
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
We need to enhance the API of this hook to increase its flexibility in handling event notifications. For example, we have a new event,
tax_id_invalid. When this event is successful (indicating the tax ID is invalid), we want to display the error variant and ensure the notification persists. Currently, there's no way to easily inverse the toast variant depending on the event.Changes 🔄
persistFailureMessagetopersisttax_id_invalidevent which is feature flaggedinvertVariantproperty to handle scenarios where a successful negative event should be represented as anerrorvariant.Target release date 🗓️
7/22
How to test 🧪
Verification steps
(How to verify changes)
volume_create:As an Author I have considered 🤔
Check all that apply