Skip to content

fix: Github CLI install link in Contributing guide#10657

Merged
hana-akamai merged 2 commits intolinode:developfrom
hana-akamai:fix-contributing-doc-link
Jul 9, 2024
Merged

fix: Github CLI install link in Contributing guide#10657
hana-akamai merged 2 commits intolinode:developfrom
hana-akamai:fix-contributing-doc-link

Conversation

@hana-akamai
Copy link
Contributor

Description 📝

Fix the github CLI link in our contributing guide leading to a 404 error

How to test 🧪

Reproduction steps

(How to reproduce the issue, if applicable)

Verification steps

(How to verify changes)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-akamai hana-akamai added the Documentation Improving / adding to our documentation label Jul 8, 2024
@hana-akamai hana-akamai self-assigned this Jul 8, 2024
@hana-akamai hana-akamai requested a review from a team as a code owner July 8, 2024 21:42
@hana-akamai hana-akamai requested review from AzureLatte and carrillo-erik and removed request for a team July 8, 2024 21:42
@github-actions
Copy link

github-actions bot commented Jul 8, 2024

Coverage Report:
Base Coverage: 82.23%
Current Coverage: 82.23%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you. 🔍

Confirmed the new link doesn't 404. Also checked the rest of the links on the Contributing page to confirm no other links are broken.

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Jul 8, 2024
Copy link
Contributor

@carrillo-erik carrillo-erik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@hana-akamai hana-akamai merged commit 8e568bc into linode:develop Jul 9, 2024
@hana-akamai hana-akamai deleted the fix-contributing-doc-link branch July 9, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Documentation Improving / adding to our documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants