change: [M3-8263] - Rename Distribution to OS#10666
Merged
hana-akamai merged 7 commits intolinode:developfrom Jul 17, 2024
Merged
change: [M3-8263] - Rename Distribution to OS#10666hana-akamai merged 7 commits intolinode:developfrom
hana-akamai merged 7 commits intolinode:developfrom
Conversation
hana-akamai
force-pushed
the
M3-8263-update-distribution-to-os
branch
from
1bf761f to
f7f2469
Compare
hana-akamai
commented
Jul 15, 2024
| @@ -0,0 +1,28 @@ | |||
| import * as React from 'react'; | |||
Contributor
Author
There was a problem hiding this comment.
Only change was a file rename
hana-akamai
requested review from
cliu-akamai,
dwiley-akamai and
jdamore-linode
and removed request for
a team
hana-akamai
changed the title
dwiley-akamai
approved these changes
Jul 15, 2024
Contributor
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
- Linode Create flow
- OS tab w/ "Linux Distribution" label for Image dropdown ✅
- other tabs still have "Images" label for Image dropdown ✅
packages/manager/src/features/Linodes/LinodesDetail/LinodeRebuild/LinodeRebuildDialog.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/ImageSelectv2/ImageSelectv2.tsx
Outdated
Show resolved
Hide resolved
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Jul 17, 2024
| onChange={onChange} | ||
| options={options} | ||
| placeholder="Choose an image" | ||
| placeholder={placeholder || 'Choose an image'} |
Member
There was a problem hiding this comment.
I think we should be preferring ?? over || generally speaking.
If we ever want to intentionally make placeholder not show, using ?? would allow us to pass an empty string whereas || would not work
bnussman-akamai
added
Approved
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Rename Distribution to OS to reduce potential confusion between Distribution and Distributed.
Changes will be released separately from Gecko LA/GA since it's just a text change and this simplifies the need for feature flagging and clean up after.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
7/22
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
OSand the Image label isLinux Distributionfor the OS tab. The Image label for other tabs should remain asImagesAs an Author I have considered 🤔
Check all that apply