feat: [M3-7683] - Disable Create Image button with tooltip text on empty state Landing Page for restricted users#10670
Merged
harsh-akamai merged 5 commits intolinode:developfrom Jul 16, 2024
Conversation
…pty state Landing Page for restricted users
…ty state Landing Page for restricted users
|
Coverage Report: ✅ |
jaalah-akamai
approved these changes
Jul 15, 2024
packages/manager/src/features/Images/ImagesLanding/ImagesLandingEmptyState.tsx
Outdated
Show resolved
Hide resolved
…ng-page-create-image-btn-for-restricted-users
mjac0bs
approved these changes
Jul 15, 2024
Contributor
mjac0bs
left a comment
There was a problem hiding this comment.
Thanks @harsh-akamai - the disabled change for restricted users and the test coverage looks good.
We'll just want to delete the most recently added changeset.
packages/manager/.changeset/pr-10670-tech-stories-1721055859684.md
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Images/ImagesLanding/ImagesLandingEmptyState.test.tsx
Outdated
Show resolved
Hide resolved
12 tasks
hkhalil-akamai
approved these changes
Jul 15, 2024
Contributor
hkhalil-akamai
left a comment
There was a problem hiding this comment.
Great work Harsh!
53fbc6c to
298942b
Compare
This was referenced Jul 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
To prevent unauthorized access to specific flows and provide clearer guidance, we aim to restrict entry to users without the required permissions.
Here, we are restricting users from creating new Image from the Empty State Landing Page when they do not have access or have read only access.
Changes 🔄
List any change relevant to the reviewer.
Target release date 🗓️
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply