upcoming: [M3-8357] – Update types and schemas for Block Storage Encryption#10716
Merged
dwiley-akamai merged 4 commits intolinode:developfrom Jul 31, 2024
Merged
Conversation
dwiley-akamai
added
the
Block Storage Encryption (BSE)
…and VolumeStatus and Capabilities types to reflect Block Storage Encryption changes
dwiley-akamai
requested review from
hkhalil-akamai and
mjac0bs
and removed request for
a team
mjac0bs
reviewed
Jul 25, 2024
Contributor
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
This looks good, and I observed no regressions to Volume creation and its payload. I left a couple of clarifying questions.
|
Coverage Report: ✅ |
hkhalil-akamai
approved these changes
Jul 30, 2024
Contributor
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
There was a problem hiding this comment.
Verified all changes in accordance with API spec and create volume flow continues to work as before.
| filesystem_path: string; | ||
| tags: string[]; | ||
| hardware_type: VolumeHardwareType; | ||
| encryption?: VolumeEncryption; // @TODO BSE: Remove optionality once BSE is fully rolled out |
Contributor
There was a problem hiding this comment.
Should we make a follow up ticket for this and bs_encryption_supported?
Contributor
Author
There was a problem hiding this comment.
Yes, there will be a ticket in the epic for addressing BSE to-do's
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Update types and schemas to reflect forthcoming Block Storage Encryption changes.
Changes 🔄
encryptionfield toVolumeandVolumeRequestPayloadinterfaces andkey_rotatingvalue toVolumeStatustype involumes/types.tskey_rotatingtovolumeStatusIconMapencryptionfield toCreateVolumeSchemaBlock Storage EncryptiontoCapabilitiestype inregions/types.tsand toAccountCapabilityinaccount/types.tsbs_encryption_supportedfield toLinodeinterface inlinodes/types.tsTarget release date 🗓️
8/5/24
How to test 🧪
Since there were changes to
CreateVolumeSchema, ensure that volume creation has not been adversely impacted.Confirm the changes are in accordance with the API spec linked in the ticket.
As an Author I have considered 🤔