upcoming: [DI-20050] - Added Data Rollup logic for graph data

[nikhagra-akamai]

Description 📝

Added data rollup logic to convert the graph data to highest possible unit based on the base unit of data we receive from widget configuration.

Changes 🔄

List any change relevant to the reviewer.

1. Added a unit conversion utility file to handle data rollup & conversion logic
2. Modified utils.ts to add a logic to generate label name for graph.
3. Modified JWE token payload from resource_id to resource_ids based on api specs
4. Updated position of message for empty data in the graph.

Target release date 🗓️

15th August 2024

Preview 📷

Include a screenshot or screen recording of the change

💡 Use <video src="" /> tag when including recordings in table.

Before	After

How to test 🧪

1. Enable mock services as some endpoints are not ready to use
2. As there is not much visual change in the UI you can simulate the unit conversion logic by passing different values & units

Note: You may notice some flickering because of continuous re-rendering but that will be resolved once global filter change handler will be implemented.

Check all that apply

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[venkymano-akamai]

LGTM, this is the same changes we have in our integrated branch

[nikhagra-akamai]

@jaalah-akamai thanks for the suggestions. I've updated those & added test cases

[jaalah-akamai]

Please take note of this issue and address it in an upcoming PR (or this one): The Grid item containing the refresh icon has styles that cause the button to overlap with the dropdown menus at smaller breakpoints. These styles should be removed to prevent this overlap, and you should probably add flex-shrink

[jaalah-akamai]

@mjac0bs / @DevDW (Added because @cpathipa is OOO) - Feel free to review when you can

[nikhagra-akamai]

Please take note of this issue and address it in an upcoming PR (or this one): The Grid item containing the refresh icon has styles that cause the button to overlap with the dropdown menus at smaller breakpoints. These styles should be removed to prevent this overlap.

@jaalah-akamai, yes this is being addressed in the separate PR which @venkymano is working on with configured global filters. Along with responsiveness for different device support.

[github-actions]

Coverage Report: ✅
Base Coverage: 82.41%
Current Coverage: 82.41%

[mjac0bs]

Left some feedback on initial pass through and will re-review once that feedback has been addressed.

[nikhagra-akamai]

@mjac0bs Thanks for the comments. I've addressed them and also created new changesets with upcoming-feature tag

[mjac0bs]

Thanks for addressing feedback @nikhagra. Error and loading states look cleaner and comments for documentation help everyone.

I've provided more detail (and hopefully more clarity) in comments about what we'd like to see for util functions with several parameters. Once those are cleaned up, this is looking in better shape to be merged.

A note to address in a future PR: there is a typo in the cloudpulse query params so they read: Clousepulse. (We also generally lowercase these, so cloudpulse would be standard here.)

[mjac0bs]

Same comment as below - please destructure your props.

Suggested change

	ariaLabel={props.ariaLabel ? props.ariaLabel : ''}
	ariaLabel={ariaLabel ?? : ''}

[nikhagra-akamai]

@mjac0bs @dwiley-akamai I've addressed comments & enhanced jsDocs. Please check & approve if all good

[mjac0bs]

Approving since most of feedback clean up has been addressed, but left some final bits of feedback for you, @nikhagra. 👍🏼

[nikhagra-akamai]

@mjac0bs thanks for the approval, I've updated the interface structure. @jaalah-akamai @mjac0bs @dwiley-akamai we've received required approval, please merge.

[dwiley-akamai]

Code review ✅
Mocked graphs ✅

[dwiley-akamai]

could use a nullish coalescing operator here

Suggested change

	ariaLabel={ariaLabel ? ariaLabel : ''}
	ariaLabel={ariaLabel ?? ''}

[mjac0bs]

The only CI failure was on smoke-community-stackscrips.spec.ts which is a result of this branch not being up to date with develop, where this was fixed earlier this week.

I'm going to merge this PR now.