upcoming: [M3-8398] - Generate firewall dialog#10770
Merged
hkhalil-akamai merged 34 commits intolinode:developfrom Aug 15, 2024
Merged
upcoming: [M3-8398] - Generate firewall dialog#10770hkhalil-akamai merged 34 commits intolinode:developfrom
hkhalil-akamai merged 34 commits intolinode:developfrom
Conversation
|
Coverage Report: ✅ |
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/GenerateFirewallDialog.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/GenerateFirewallDialog.test.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
packages/manager/src/components/GenerateFirewallDialog/useCreateFirewallFromTemplate.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
Good point. Let me follow up with UX about this Edit: UX confirmed button should be moved to the right. |
packages/manager/src/components/GenerateFirewallDialog/GenerateFirewallDialog.tsx
Outdated
Show resolved
Hide resolved
carrillo-erik
approved these changes
Aug 14, 2024
Contributor
carrillo-erik
left a comment
There was a problem hiding this comment.
Looks good, nice work getting this completed.
jaalah-akamai
approved these changes
Aug 15, 2024
Contributor
jaalah-akamai
left a comment
There was a problem hiding this comment.
I think the loader can be improved on the second generation of a FW, but otherwise this looks good. nice job!
e18976f to
e3e5015
Compare
bnussman-akamai
approved these changes
Aug 15, 2024
Member
bnussman-akamai
left a comment
There was a problem hiding this comment.
Looks good! Nice job on this one
This was referenced Aug 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description 📝
Implements the generate firewall dialog, which guides users through the process of generating a compliant firewall from a template.
Changes 🔄
api-v4packageGenerateFirewallDialogcomponent that steps users through generating a firewall from a templateuseCreateFirewallFromTemplatewhich exposes a script to fetch firewall templates, select a label and create the new firewallFirewallLandingand Linode create flowsreplaceNewlinesWithLineBreaksto handle rendering multi-line content from LDTarget release date 🗓️
8/19
Preview 📷
See the internal ticket.
How to test 🧪
See the internal ticket.
As an Author I have considered 🤔
Check all that apply