test: [M3-8454] - Cypress test for Secure VMs firewall generation

[hkhalil-akamai]

Description 📝

Add Cypress tests to verify the flow to generate compliant firewalls in the Linode Create form.

This flow can also be initiated from the banners in FirewallLanding and FirewallDetails but since those are already covered by unit tests, and the component is shared, I decided to only write tests for generating firewalls through the Linode create flow.

Target release date 🗓️

9/3

How to test 🧪

• Verify Cypress tests pass

As an Author I have considered 🤔

Check all that apply

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[hkhalil-akamai]

This header is removed in a global interceptor, so we have to manually re-add it for this request.

[hkhalil-akamai]

The value of watchFirewall becomes null after clearing (create v2).

[hkhalil-akamai]

The value of firewallId becomes -1 after clearing (create v1).

[AzureLatte]

Thank you!

[github-actions]

Coverage Report: ✅
Base Coverage: 82.73%
Current Coverage: 82.73%

[hkhalil-akamai]

@cliu-akamai @harsh-akamai this PR is ready for review whenever you are able. Thanks!

[harsh-akamai]

Suggested change

	linodeCreatePage.selectRegionById(linodeRegion.id);
	linodeCreatePage.selectRegionById(linodeRegion.label);

Not sure if this is applicable only for me, but all the tests seem to fail when I use id instead of label

[hkhalil-akamai]

I was encountering this issue too, but it only occurs when running tests locally with the Gecko v2 GA flag enabled.

manager/packages/manager/src/components/RegionSelect/RegionSelect.tsx

Lines 122 to 124 in 6c9ad93

	getOptionLabel={(region) =>
	isGeckoGAEnabled ? region.label : `${region.label} (${region.id})`
	}

[hkhalil-akamai]

We may have to change all instances like this in the near future if GA becomes permanent and the flag is retired (cc @jdamore-linode)

[jdamore-linode]

Hey @hkhalil-akamai, I can't run the tests locally right now because I'm running DC tests, but is this failing because Cypress is typing the region ID into a region select field and the desired region is not showing up? If so, I believe that's a Gecko bug (M3-8502) rather than an issue with the tests.