upcoming: [DI-20284] - Added support for multiple services in the dashboards list#10805
Conversation
nikhagra-akamai
requested review from
AzureLatte and
harsh-akamai
and removed request for
a team
nikhagra-akamai
requested review from
jdamore-linode
and removed request for
a team
…filters when dashboard changes
nikhagra-akamai
force-pushed
the
missing-api-params
branch
from
78e6ec0 to
c55ea4e
Compare
jcallahan-akamai
requested review from
bnussman-akamai
and removed request for
AzureLatte and
harsh-akamai
|
Thanks @bnussman-akamai for approval. @jdamore-linode please review and provide other approval if all good |
|
Coverage Report: ✅ |
|
|
||
| // Returns the list of all the dashboards available | ||
| export const getDashboards = () => | ||
| export const getDashboards = (serviceType: string) => |
There was a problem hiding this comment.
If this is a paginated response, should we add setParams(params) and also setFilters(filters)?
There was a problem hiding this comment.
for our beta release pagination is not required. Later we will update it because some other endpoints are also paginated
| } | ||
|
|
||
| export interface ServiceTypesList { | ||
| data: ServiceTypes[]; |
There was a problem hiding this comment.
nit: Something to consider, is there a more descriptive name we can use rather than data as to avoid data.data in places?
There was a problem hiding this comment.
We are receiving the "data" as response key from API itself because it is a paginated response
"data": [ { "service_type": "linode" } ],
5 participants
Description 📝
Modified dashboard select component to support multiple service types in the list. Also modified api request params based on API spec.
Changes 🔄
Target release date 🗓️
30 August 2024
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Note: Some re-rendering is there and its fix is going on but this PR is raised to add some API changes urgently.
As an Author I have considered 🤔
Check all that apply