Skip to content

test: [M3-7287] - Add new test for the NodeBalancer Create flow for multiple nodes and multiple configs#10825

Merged
AzureLatte merged 4 commits intolinode:developfrom
AzureLatte:M3-7287
Sep 10, 2024
Merged

test: [M3-7287] - Add new test for the NodeBalancer Create flow for multiple nodes and multiple configs#10825
AzureLatte merged 4 commits intolinode:developfrom
AzureLatte:M3-7287

Conversation

@AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented Aug 23, 2024

Description 📝

Add new Cypress tests for the NodeBalancer Create flow to test the submission of multiple nodes and multiple configs.

Changes 🔄

  • Add new tests in nodebalancers/nodebalancers-create-in-complex-form.spec.ts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/nodebalancers/nodebalancers-create-in-complex-form.spec.ts"

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@AzureLatte AzureLatte self-assigned this Aug 23, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner August 23, 2024 16:00
@AzureLatte AzureLatte requested review from cliu-akamai and removed request for a team August 23, 2024 16:01
@AzureLatte AzureLatte requested a review from a team as a code owner August 23, 2024 16:03
@AzureLatte AzureLatte requested review from abailly-akamai and jdamore-linode and removed request for a team August 23, 2024 16:03
@github-actions
Copy link

github-actions bot commented Aug 23, 2024

Coverage Report:
Base Coverage: 82.62%
Current Coverage: 82.62%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passing on my end and code looks good, thx for the improved coverage!

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed tests pass locally - thanks for added coverage! 🎉

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Sep 10, 2024
@AzureLatte AzureLatte merged commit 66f43b3 into linode:develop Sep 10, 2024
@AzureLatte AzureLatte deleted the M3-7287 branch September 10, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants