chore: [M3-8262] - Cleanup eventMessages flag and legacy code#10839
chore: [M3-8262] - Cleanup eventMessages flag and legacy code#10839abailly-akamai merged 10 commits intolinode:developfrom
Conversation
abailly-akamai
changed the title
abailly-akamai
force-pushed
the
M3-8262
branch
from
669fb31 to
e56dd1c
Compare
abailly-akamai
force-pushed
the
M3-8262
branch
from
04f175a to
19acdbc
Compare
| </> | ||
| ); | ||
| } | ||
| ); |
There was a problem hiding this comment.
This and underneath isn't new code, it's just been broken down - logic is the same
| borderBottom: `1px solid ${theme.bg.main}`, | ||
| position: 'relative', | ||
| }, | ||
| })); |
There was a problem hiding this comment.
Following our standards, broke styles and types into own files
no new code here
| 'community_mention', | ||
| 'community_question_reply', | ||
| ]; | ||
|
|
There was a problem hiding this comment.
this was moved from a file that was deleted (this block was added after the initial refactor)
abailly-akamai
requested review from
bnussman-akamai,
hana-akamai and
jdamore-linode
and removed request for
a team
|
Coverage Report: ✅ |
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Congrats on the clean up, look at that diff. 🎉 (We should remember to archive the LD flag after the release goes out too.)
Reorganizations and renamings make sense! Long, but clear and consistent, component names. 👍🏼
Didn't see any regressions after testing some events locally. CI had some trouble with a couple runners, but local runs of those tests looked good.
@mjac0bs yeah i struggled a bit with a decent convention but "Notification" in itself isn't conveying enough context. My take was that the names here makes it easier to find references for contributors in their IDE, and by compile time/minification the name length matters little. |
3 participants
Description 📝
This PR is a follow up to EventMessages v2 implementation. Now that the flag has been
onin production and no major (or minor for that regard) bugs has been reported, it's time to clean up the legacy code and ordganize the code around the features EventMessages v2 introduced and implemented.This refactor was facilited by targeting all instances of
TODO eventMessagesV2left in the codebase to this purpose.This PR does not modify behavior or styling in any way (read shouldn't), it only reorganizes the code around the cleanup.
Changes 🔄
Preview 📷
Include a screenshot or screen recording of the change
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Verify that no regression happens as a result of this cleanup
As an Author I have considered 🤔
Check all that apply