Skip to content

change: [M3-8425, M3-8231] - Update TypeScript and Vitest#10843

Merged
bnussman-akamai merged 3 commits intolinode:developfrom
bnussman-akamai:M3-8425-update-to-typescript-5.5
Aug 29, 2024
Merged

change: [M3-8425, M3-8231] - Update TypeScript and Vitest#10843
bnussman-akamai merged 3 commits intolinode:developfrom
bnussman-akamai:M3-8425-update-to-typescript-5.5

Conversation

@bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Aug 27, 2024

Description 📝

  • Updates TypeScript and Vitest 📦
  • Remove npm-run-all and postinstall because we don't use them 🗑️
  • I wanted to update just Typescript initially, but I was having issues getting Vitest's types to play nicely so I'm just going to give this a shot and see what happens

How to test 🧪

  • Test local development
  • Test production build (checking an internal preview link is sufficient)
  • Verify Storybook still works locally
  • Verify type-checking passes in GitHub Actions
  • Verify Storybook builds in GitHub Actions for all packages
  • Verify unit tests pass in GitHub Actions for all packages

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Aug 27, 2024
@bnussman-akamai bnussman-akamai self-assigned this Aug 27, 2024
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner August 27, 2024 20:30
@bnussman-akamai bnussman-akamai requested review from cpathipa and dwiley-akamai and removed request for a team August 27, 2024 20:30
@github-actions
Copy link

github-actions bot commented Aug 27, 2024

Coverage Report:
Base Coverage: 82.73%
Current Coverage: 85.96%

@bnussman-akamai bnussman-akamai changed the title poc: Update TypeScript, Vite, and Vitest poc: Update TypeScript and Vitest Aug 27, 2024
@bnussman-akamai bnussman-akamai changed the title poc: Update TypeScript and Vitest change: [M3-8425, M3-8231] - Update TypeScript and Vitest Aug 27, 2024
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test local development ✅
Internal preview link ✅
Storybook still works locally ✅
Type-checking passes in GitHub Actions ✅
Storybook builds in GitHub Actions for all packages ✅
Unit tests pass in GitHub Actions for all packages ✅

Let's add a Tech Story changeset for this 👍🏾

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 28, 2024
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnussman Thank you for updating TS and Vitest, confirming on the verification steps.

@cpathipa cpathipa added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 29, 2024
@bnussman-akamai bnussman-akamai merged commit 8176f7a into linode:develop Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants