Skip to content

change: [M3-8379] - Disable Region in OS tab for unsupported distributed images#10848

Merged
hana-akamai merged 5 commits intolinode:developfrom
hana-akamai:M3-8379-disable-region-unsupported-distro-os
Aug 29, 2024
Merged

change: [M3-8379] - Disable Region in OS tab for unsupported distributed images#10848
hana-akamai merged 5 commits intolinode:developfrom
hana-akamai:M3-8379-disable-region-unsupported-distro-os

Conversation

@hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Aug 28, 2024

Description 📝

Not all Linux Distributions in the Linode Create OS tab support distributed regions. We want to disable a region if the selected OS does not have a distributed capability similar to the Images tab

Changes 🔄

  • Remove specific check for linodeCreateTab in getDisabledRegions so that any selected image that does not have the distributed-sites capability is disabled
  • Minor UI positioning fix for distributed helper text w/ region error text

Preview 📷

Gecko Before After
Beta v2-beta-before-os v2-beta-after-os
Beta image image
LA / GA v2-la-before-os v2-la-after-os

How to test 🧪

Prerequisites

(How to setup test environment)

  • Ensure your account has the new-dc-testing, new-dc-testing-gecko, edge_testing and edge_compute customer tags
  • Pull this PR and run it locally pointing to dev API

Reproduction steps

(How to reproduce the issue, if applicable)

  • Checkout develop locally while pointing to the dev API
  • Go to the Linode Create flow
  • Notice that distributed regions are not disabled for unsupported distributed images (no distributed icon, e.g. Debian 11)

Verification steps

(How to verify changes)

  • Go to the Linode Create flow and verify the v1 and v2 flows for Gecko Beta & Gecko LA/GA
    • To test Gecko Beta locally, you can add the following to useFlags.ts:
    • We do not want to change the LD flag globally since other teams rely on it
    • ...mockFlags,
      gecko2: {
      enabled: true,
      ga: false
      }
  • Verify unsupported distributed regions (no distributed icon, e.g. Debian 11)
    • Gecko LA/GA: Regions in the Distributed tab should be disabled with tooltip
    • Gecko Beta: Distributed regions in the single dropdown should be disabled with tooltip
  • Verify supported distributed regions (distributed icon, e.g. Ubuntu 24.04 LTS)
    • Gecko LA/GA: Regions in the Distributed tab should not be disabled
    • Gecko Beta: Distributed regions in the single dropdown should not be disabled

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@hana-akamai hana-akamai added the Gecko Beta Relating to Gecko project label Aug 28, 2024
@hana-akamai hana-akamai self-assigned this Aug 28, 2024
@hana-akamai hana-akamai changed the title feat: [M3-8379] - Disable Region in OS tab for unsupported distributed images change: [M3-8379] - Disable Region in OS tab for unsupported distributed images Aug 28, 2024
@hana-akamai hana-akamai marked this pull request as ready for review August 28, 2024 18:58
@hana-akamai hana-akamai requested a review from a team as a code owner August 28, 2024 18:58
@hana-akamai hana-akamai requested review from coliu-akamai and mjac0bs and removed request for a team August 28, 2024 18:58
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see Gecko and Image Service Gen2 finally come together 🎉

Thanks for fixing the alignment issues too

@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Aug 29, 2024
@github-actions
Copy link

Coverage Report:
Base Coverage: 86.08%
Current Coverage: 86.08%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verify unsupported distributed regions (no distributed icon, e.g. Debian 11) - both Gecko Beta and LA/GA
✅ Verify supported distributed regions (distributed icon, e.g. Ubuntu 24.04 LTS) - both Gecko Beta and LA/GA

🚀 🎉

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Aug 29, 2024
@hana-akamai hana-akamai merged commit 579d418 into linode:develop Aug 29, 2024
@hana-akamai hana-akamai deleted the M3-8379-disable-region-unsupported-distro-os branch August 29, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Gecko Beta Relating to Gecko project

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants